foreign asset creator pallet #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
reviewed
Dec 12, 2023
| ] | ||
|
|
||
| runtime-benchmarks = [ "frame-benchmarking" ] | ||
| try-runtime = [ "frame-support/try-runtime" ] |
There was a problem hiding this comment.
Now try-runtime is a separate binary, so we don't need this rust feature anymore
librelois
approved these changes
Dec 12, 2023
|
@girazoki can you merge master? |
|
will do yes |
…oreign-asset-creator
|
Done @librelois but I still want to push some benchmarking code |
|
@librelois this should be now ready tpo be merged |
girazoki
added a commit
to moondance-labs/moonkit
that referenced
this pull request
Jan 9, 2024
* foreign asset creator pallet * add maybe equivalence * lock * Add benchmarks * benchmarks * at least 16 bit unsigned * update * add benchmarks * add weights· * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a pallet that is similar to the asset-manager from moonbeam but it is a simplified version of it. In this case, the foreign-asset-creator-pallet is only responsible for creating and maintaining an
assetId<->ForeignAssetmapping to ease the following situations:assetIdto touch whenever we receive an XCMMultiAssetMultiAssetto send when we are told to send a specificassetIdto another chainImportant changes:
We allow the creator to decide an
assetIdinstead of deriving it ourselves through some other mechanism. The main reason for having a custom derivation for theassetIdwas that one could find a collision with a smart contract on the precompile address, but I believe this case is very ethereum specific and could be addressed in different manners (for instance, by using a smallerassetIdtype)No units per second, this if needed should be done in a different pallet
No local asset creation