Improves implementation of generic types #43
+3,963
−1,630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 9, 2017 17:44
lukasoyen
requested changes
Jun 8, 2017
| @@ -0,0 +1,30 @@ | |||
| #Dont use maven directly, because all maven dependencies downloaded during build time won't be in the image | |||
There was a problem hiding this comment.
Do we need a dockerfile? I guess it's fine.
| You can also install Graphviz to generate class diagrams. This is optional. | ||
|
|
||
| choco install graphviz | ||
| Currently Windows is not supported. |
There was a problem hiding this comment.
Could you expand on why Windows is not supported anymore?
There was a problem hiding this comment.
There were a few reasons.
One that i can remember is reading from command line produces different line endings. So the unit tests fail on windows.
| <compilerSource>1.7</compilerSource> | ||
| <compilerCompliance>1.7</compilerCompliance> | ||
| <compilerTargetPlatform>1.7</compilerTargetPlatform> | ||
| <compilerSource>1.8</compilerSource> |
There was a problem hiding this comment.
I think we need a JDK version bump in the .travis-ci.yml aswell, to make Travis happy.
| @@ -137,6 +139,18 @@ private static boolean visitVisitors(Package ast, boolean stopOnFirstError, Stri | |||
| } | |||
| } | |||
|
|
|||
| if(everyThingIsAwesome) { | |||
| @@ -254,64 +234,46 @@ public void visitChildren(BaseVisitor visitor) { | |||
| for (VariableDeclaration variableDeclaration : parameters) { | |||
| visitor.visitDoubleDispatched(variableDeclaration); | |||
| } | |||
| // if(wrapperFunctionObjectDeclaration != null){ | |||
There was a problem hiding this comment.
Unnecessary code is unnecessary (happens a few times)? Yet again, I don't really care.
|
And you could update https://github.com/MontysCoconut/moco/blob/master/FEATURES.md :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.