Fix remove by destination type, add tests.

Mono-Empire · Jul 1, 2024 · c10614c · c10614c
1 parent 39852cf
commit c10614c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -6,3 +6,4 @@ DerivedData/
 .swiftpm/configuration/registries.json
 .swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
 .netrc
+/.idea
diff --git a/Sources/MELogger/Managers/MELoggerDestinationManager.swift b/Sources/MELogger/Managers/MELoggerDestinationManager.swift
@@ -65,7 +65,7 @@ final public class MELoggerDestinationManager: @unchecked Sendable {
     /// - Parameter destinationType: The class of the destination to remove.
     public func remove(type destinationType: MELoggerDestination.Type) {
         self.loggerDestinationListMutatingLock.sync {
-            self.destinations = []
+            self.destinations.removeAll(where: { type(of: $0) == destinationType })
         }
     }
 

diff --git a/Tests/MELoggerTests/MELoggerTests.swift b/Tests/MELoggerTests/MELoggerTests.swift
@@ -115,9 +115,18 @@ class MELoggerTests: XCTestCase {
         XCTAssertEqual(1, anotherMockLogDestination.loggedMessages.count)
         XCTAssertNotNil(self.mockLogDestination.lastLoggedMessage)
         XCTAssertEqual(2, self.mockLogDestination.loggedMessages.count)
-
     }
-
+
+    func testAddRemoveLoggerDestionations() {
+        XCTAssertEqual(MELoggerDestinationManager.shared.getDestinations().count, 0)
+        let fileLoggerDestination = FileLoggerDestination()
+        MELoggerDestinationManager.shared.add(self.mockLogDestination)
+        MELoggerDestinationManager.shared.add(fileLoggerDestination)
+        XCTAssertEqual(MELoggerDestinationManager.shared.getDestinations().count, 2)
+        MELoggerDestinationManager.shared.remove(type: FileLoggerDestination.self)
+        XCTAssertEqual(MELoggerDestinationManager.shared.getDestinations().count, 1)
+    }
+
     func testConsoleLoggerDestination() {
 
         let settings = ConsoleLoggerDestination.Settings(isEnabled: true)