Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改网站 密码 和 cookie 的散列计算方式 #252

Merged
merged 5 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions lib/class.P.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,53 @@ public function __construct($salt = '')
}

/**
* 对数据(通常是密码)进行不可逆加密
* [弃用] 对数据(通常是密码)进行不可逆加密
* @param string $pwd 密码
* @return string 加密的密码
*/
public function pwd($pwd)
public function legacy_pwd($pwd)
{
return eval('return ' . option::get('pwdmode') . ';');
}

/**
* 对数据(通常是密码)进行不可逆加密
* @param string $pwd 密码
* @param boolean $with_legacy 是否包含旧密码(不支持 `password_hash()` 时无效)
* @return string|object 新密码(和带旧版密码的 array)
*/
public function pwd($pwd, $with_legacy = false)
{
if (function_exists("password_hash")) {
$newHash = password_hash($pwd, PASSWORD_BCRYPT, ["cost" => 12]);
if ($with_legacy) {
$legacy_hash = $this->legacy_pwd($pwd);
return [
"new" => $newHash,
"legacy" => $legacy_hash,
];
} else {
return $newHash;
}
} else {
return $this->legacy_pwd($pwd);
}
}

/**
* 校验密码是否合法
* @param string $pwd 密码
* @return boolean 密码是否合法
*/
public function pwd_verify($pwd, $hash)
{
if (function_exists("password_verify") && password_verify($pwd, $hash)) {
return true;
}
// legacy
return $hash === $this->legacy_pwd($pwd);
}

/**
* 对数据进行可逆加密
* @param string $str 原文
Expand Down
10 changes: 5 additions & 5 deletions lib/globals.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
$con_uid = isset($_COOKIE['uid']) ? sqladds($_COOKIE['con_uid']) : '';
$con_pw = isset($_COOKIE['pwd']) ? sqladds($_COOKIE['con_pwd']) : '';
$con_p = $m->once_fetch_array("SELECT * FROM `" . DB_NAME . "`.`" . DB_PREFIX . "users` WHERE `id` = '{$con_uid}' LIMIT 1");
if (empty($con_p['id']) || $con_pw != substr(sha1(EncodePwd($con_p['pw'])), 4, 32)) {
if (empty($con_p['id']) || hash_hmac('sha256', $con_p['pw'], $con_p['id'] . $con_p['pw']) !== $con_pw) {
setcookie("con_uid", '', time() - 3600);
setcookie("con_pwd", '', time() - 3600);
} else {
Expand Down Expand Up @@ -42,7 +42,7 @@
}
doAction('globals_1');
$p = $m->fetch_array($osq);
if ($pw != substr(sha1(EncodePwd($p['pw'])), 4, 32)) {
if (hash_hmac('sha256', $p['pw'], $p['id'] . $p['pw']) !== $pw) {
setcookie("uid", '', time() - 3600);
setcookie("pwd", '', time() - 3600);
ReDirect("index.php?mod=login&error_msg=" . urlencode('Cookies 所记录的账号信息不正确,请重新登录(#2)') . "");
Expand Down Expand Up @@ -135,7 +135,7 @@
die;
}
$p = $m->fetch_array($osq);
if (EncodePwd($pw) != $p['pw']) {
if (!VerifyPwd($pw, $p['pw'])) {
ReDirect("index.php?mod=login&error_msg=" . urlencode('密码错误'));
die;
} else {
Expand All @@ -147,11 +147,11 @@
$cktime = 999999;
}
setcookie("uid", $p['id'], time() + $cktime);
setcookie("pwd", substr(sha1(EncodePwd(EncodePwd($pw))), 4, 32), time() + $cktime);
setcookie("pwd", hash_hmac('sha256', $p['pw'], $p['id'] . $p['pw']), time() + $cktime);
ReDirect('index.php');
} else {
setcookie("uid", $p['id']);
setcookie("pwd", substr(sha1(EncodePwd(EncodePwd($pw))), 4, 32));
setcookie("pwd", hash_hmac('sha256', $p['pw'], $p['id'] . $p['pw']));
ReDirect('index.php');
}
}
Expand Down
18 changes: 15 additions & 3 deletions lib/sfc.functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,25 @@ function getIp()
/**
* 加密密码
* @param string $pwd 密码
* @return string 加密的密码
* @param boolean $with_legacy 是否包含旧密码
* @return string|object 新密码和旧版密码
*/
function EncodePwd($pwd)
function EncodePwd($pwd, $with_legacy = false)
{
$p = new P();
return $p->pwd($pwd, $with_legacy);
}

/**
* 校验密码
* @param string $pwd 密码
* @param string $hash hash 值
* @return boolean 密码是否合法
*/
function VerifyPwd($pwd, $hash)
{
$p = new P();
return $p->pwd($pwd);
return $p->pwd_verify($pwd, $hash);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion setup/install.template.sql
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ DROP TABLE IF EXISTS `{VAR-PREFIX}users`;
CREATE TABLE `{VAR-PREFIX}users` (
`id` int(30) NOT NULL AUTO_INCREMENT,
`name` varchar(20) NOT NULL,
`pw` char(32) NOT NULL,
`pw` TEXT NOT NULL,
`email` varchar(40) NOT NULL,
`role` varchar(10) NOT NULL DEFAULT 'user',
`t` varchar(20) NOT NULL DEFAULT 'tieba',
Expand Down
17 changes: 17 additions & 0 deletions setup/update5.00to5.01.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

define('SYSTEM_DEV', true);
define('SYSTEM_NO_CHECK_VER', true);
define('SYSTEM_NO_CHECK_LOGIN', true);
define('SYSTEM_NO_PLUGIN', true);
include __DIR__ . '/../init.php';
global $m,$i;
$cv = option::get('core_version');
if (!empty($cv) && $cv >= '5.01') {
msg('您的云签到已升级到 V5.01 版本,请勿重复更新<br/><br/>请立即删除 /setup/update5.00to5.01.php');
}
$m->query("ALTER TABLE `" . DB_PREFIX . "users` CHANGE `pw` `pw` TEXT;", true);

option::set('core_version', '5.01');
unlink(__FILE__);
msg('您的云签到已成功升级到 V5.01 版本,请立即删除 /setup/update5.00to5.01.php,谢谢', SYSTEM_URL);