Fix logging for failed load.

ModOrganizer2 · Aug 11, 2024 · e155907 · e155907
1 parent 54e05d3
commit e155907
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/proxy/proxypython.cpp b/src/proxy/proxypython.cpp
@@ -121,7 +121,7 @@ QList<QList<QObject*>> ProxyPython::load(const PluginExtension& extension)
     }
 
     if (extension.autodetect()) {
-        log::error("{}: automatic plugin detection is not supported for Python plugins",
+        log::debug("{}: automatic plugin detection is not supported for Python plugins",
                    extension.metadata().name());
         return {};
     }

diff --git a/src/runner/pythonrunner.cpp b/src/runner/pythonrunner.cpp
@@ -174,6 +174,13 @@ namespace mo2::python {
                 // load the module
                 auto spec =
                     importlib_util.attr("spec_from_file_location")(name, pythonModule);
+
+                if (Py_IsNone(spec.ptr())) {
+                    MOBase::log::error("failed to load Python plugin '{}' from '{}'",
+                                       name, pythonModule);
+                    return {};
+                }
+
                 pymodule = importlib_util.attr("module_from_spec")(spec);
                 sys.attr("modules")[py::str(name)] = pymodule;
                 spec.attr("loader").attr("exec_module")(pymodule);