Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nmslib-metabrainz for Python 3.11 and upper #180

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

chezou
Copy link
Contributor

@chezou chezou commented Aug 15, 2024

Description

The official nmslib doesn't provide wheels for Python 3.11 and 3.12. For convenience, let's allow the use of the forked version wheel, i.e., nmslib-metabrainz.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
    • Yes
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
    • No need to update docstring
  • Does your change require any new tests?
    • No
  • Have you updated the changelog file?

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (72d14b8).
Report is 65 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #180     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        56     +11     
  Lines         2242      3451   +1209     
===========================================
+ Hits          2242      3451   +1209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feldlime
Copy link
Collaborator

@chezou Nice solution, thanks!

@feldlime feldlime merged commit 3e028cd into MobileTeleSystems:main Aug 27, 2024
9 checks passed
@chezou chezou deleted the nmslib-311 branch August 27, 2024 18:57
blondered pushed a commit that referenced this pull request Sep 23, 2024
The official nmslib doesn't provide wheels for Python 3.11 and 3.12. For
convenience, let's allow the use of the forked version wheel, i.e.,
nmslib-metabrainz.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants