Fixed mypy error: changed Dict to Mapping in calc_metrics and `sele…

…ct_by_type`.
MobileTeleSystems · Aug 5, 2024 · db3cdff · db3cdff
1 parent 8e0783f
commit db3cdff
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/rectools/metrics/scoring.py b/rectools/metrics/scoring.py
@@ -34,7 +34,7 @@
 
 
 def calc_metrics(  # noqa  # pylint: disable=too-many-branches,too-many-locals,too-many-statements
-    metrics: tp.Dict[str, MetricAtK],
+    metrics: tp.Mapping[str, MetricAtK],
     reco: pd.DataFrame,
     interactions: tp.Optional[pd.DataFrame] = None,
     prev_interactions: tp.Optional[pd.DataFrame] = None,

diff --git a/rectools/utils/misc.py b/rectools/utils/misc.py
@@ -137,7 +137,7 @@ def is_instance(obj: tp.Any, types: tp.Union[AnyType, tp.Tuple[AnyType, ...]]) -
 
 
 def select_by_type(
-    objects: tp.Dict[tp.Any, tp.Any],
+    objects: tp.Mapping[tp.Any, tp.Any],
     types: tp.Union[AnyType, tp.Tuple[AnyType, ...]],
 ) -> tp.Dict[tp.Any, tp.Any]:
     """

diff --git a/tests/metrics/test_scoring.py b/tests/metrics/test_scoring.py
@@ -173,7 +173,7 @@ def test_raises(self, metric: MetricAtK, arg_names: tp.List[str]) -> None:
 
     def test_success_debias(self) -> None:
         debias_config = DebiasConfig(iqr_coef=1.5, random_state=32)
-        debias_metrics = {
+        debiased_metrics = {
             "debiased_precision@3": Precision(k=3, debias_config=debias_config),
             "debiased_rprecision@3": Precision(k=3, r_precision=True, debias_config=debias_config),
             "debiased_recall@3": Recall(k=3, debias_config=debias_config),
@@ -207,13 +207,13 @@ def test_success_debias(self) -> None:
         debiased_interactions = debias_interactions(self.interactions, config=debias_config)
 
         actual = calc_metrics(
-            metrics=debias_metrics,  # type: ignore
+            metrics=debiased_metrics,
             reco=self.reco,
             interactions=self.interactions,
             catalog=self.catalog,
         )
         expected = calc_metrics(
-            metrics=metrics,  # type: ignore
+            metrics=metrics,
             reco=self.reco,
             interactions=debiased_interactions,
             catalog=self.catalog,