Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Xcode schemes #385

Merged
merged 76 commits into from
May 4, 2022
Merged

Generate Xcode schemes #385

merged 76 commits into from
May 4, 2022

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented May 2, 2022

Closes #101.

@cgrindel cgrindel self-assigned this May 2, 2022
@cgrindel cgrindel force-pushed the cg/gh101_generate_schemes branch 2 times, most recently from f66c5a2 to 9f4dd6b Compare May 3, 2022 22:30
@cgrindel cgrindel force-pushed the cg/gh101_generate_schemes branch from 2412080 to 2e56c05 Compare May 4, 2022 16:03
@cgrindel cgrindel changed the base branch from main to cg/gh101_refactor_pbxtargets May 4, 2022 16:03
Base automatically changed from cg/gh101_refactor_pbxtargets to main May 4, 2022 16:08
@cgrindel cgrindel force-pushed the cg/gh101_generate_schemes branch from 2e56c05 to 802e891 Compare May 4, 2022 16:21
@cgrindel cgrindel marked this pull request as ready for review May 4, 2022 16:27
@cgrindel
Copy link
Contributor Author

cgrindel commented May 4, 2022

@brentleyjones The integration test is failing because Bazel Dependencies.xcscheme filename has a space in it. I believe that this is related to this known Bazel issue. To declare victory on this PR, I can do one of the following:

  1. Change the product name to BazelDependencies (no space).
  2. Disable the integration test.

I created bazel-contrib/rules_bazel_integration_test#62 to track the issue.

@cgrindel cgrindel requested a review from brentleyjones May 4, 2022 16:45
brentleyjones
brentleyjones reviewed May 4, 2022
View reviewed changes
tools/generator/src/Generator+CreateXCSchemes.swift Outdated Show resolved Hide resolved
tools/generator/src/Generator+CreateXCSchemes.swift Outdated Show resolved Hide resolved
tools/generator/src/Generator+CreateXCSchemes.swift Outdated Show resolved Hide resolved
tools/generator/src/Generator+CreateXCSchemes.swift Outdated Show resolved Hide resolved
tools/generator/src/Generator+CreateXCSchemes.swift Outdated Show resolved Hide resolved
tools/generator/src/Generator+SetTargetDependencies.swift Outdated Show resolved Hide resolved
tools/generator/src/Generator+SetTargetDependencies.swift Outdated Show resolved Hide resolved
tools/generator/src/TargetID.swift Outdated Show resolved Hide resolved
tools/generator/test/GeneratorTests.swift Outdated Show resolved Hide resolved
tools/generator/test/GeneratorTests.swift Outdated Show resolved Hide resolved
@cgrindel cgrindel force-pushed the cg/gh101_generate_schemes branch from 9e96ff0 to 33587fe Compare May 4, 2022 20:07
@cgrindel cgrindel force-pushed the cg/gh101_generate_schemes branch from 33587fe to 26a6e4a Compare May 4, 2022 20:15
@cgrindel cgrindel requested a review from brentleyjones May 4, 2022 20:17
brentleyjones
brentleyjones reviewed May 4, 2022
View reviewed changes
..._line/bwb.xcodeproj/xcshareddata/xcschemes/LibSwiftTests.__internal__.__test_bundle.xcscheme Show resolved Hide resolved
..._line/bwb.xcodeproj/xcshareddata/xcschemes/LibSwiftTests.__internal__.__test_bundle.xcscheme
Comment on lines +7 to +8
<BuildActionEntries>
</BuildActionEntries>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode removes these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what we get from tuist/Xcode.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck. Seems that the array should be [Entry]? instead then.

@cgrindel cgrindel requested a review from brentleyjones May 4, 2022 20:30
@cgrindel cgrindel enabled auto-merge (squash) May 4, 2022 20:31
brentleyjones
brentleyjones approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

@cgrindel cgrindel merged commit 3624a0d into main May 4, 2022
@cgrindel cgrindel deleted the cg/gh101_generate_schemes branch May 4, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

Assignees

@cgrindel cgrindel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create schemes
2 participants
@cgrindel @brentleyjones