Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectral slope functions #19

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Spectral slope functions #19

wants to merge 18 commits into from
+3,222,374 −43

Conversation

MitchellAcoustics
Copy link
Owner

No description provided.

MitchellAcoustics and others added 15 commits January 27, 2021 19:25
@MitchellAcoustics
Add parameters.py definitions to functional branch
1f9b136
@MitchellAcoustics
tests failing - directory discovery errors
3564152
@MitchellAcoustics
updating complex_paqs calc
a9b4b5e
@MitchellAcoustics
add collect_dirs example
d502f32
@MitchellAcoustics
update README
167ad8d
@MitchellAcoustics
update README
a38873c
@MitchellAcoustics
adding test directories
5045279
@MitchellAcoustics
update directory lists
43dfd4c
@MitchellAcoustics
Add basic function for 2D spectrogram plotting
6d82b74 
Need to add tests and docs
@MitchellAcoustics
test 2ch spectrogram basic method
0849143
@MitchellAcoustics
reorganise modules
67c2d2e
@MitchellAcoustics
Add ISO532-1 loudness from wav calcs
9b225e3 
This implements the .exe from the iso to calculate
stationary or time-varying loudness from a wav file.
Does NOT handle capturing the .csv outputs from the
ISO .exe function. Examples of these have been saved
as they are outputted, but should be captured and deleted.

Some tests written for loudness funcs
@MitchellAcoustics
solved default ref_level failing test
f66d8b5
@MitchellAcoustics
First function added, no files to test on
3e66950
Add test TS files for LocationA1 (CamdentTown1)
c4828b6
@sourcery-ai sourcery-ai bot mentioned this pull request Jan 28, 2022
Merged
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Sourcery AI and others added 2 commits January 28, 2022 15:39
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 28, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 12.10%.

Quality metrics Before After Change
Complexity 4.05 ⭐ 7.13 ⭐ 3.08 👎
Method Length 51.21 ⭐ 67.07 🙂 15.86 👎
Working memory 8.79 🙂 9.84 🙂 1.05 👎
Quality 72.85% 🙂 60.75% 🙂 -12.10% 👎
Other metrics Before After Change
Lines 801 396 -405
Changed files Quality Before Quality After Quality Change
soundscapy/analysis.py % 48.71% 😞 %
soundscapy/test/test_database.py 87.00% ⭐ 83.79% ⭐ -3.21% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
soundscapy/analysis.py loudness_from_wav 20 😞 257 ⛔ 13 😞 31.83% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
soundscapy/analysis.py spectrogram_2ch 8 ⭐ 214 ⛔ 16 ⛔ 40.56% 😞 Try splitting into smaller methods. Extract out complex expressions
soundscapy/test/test_database.py test_calculate_complex_paqs 0 ⭐ 146 😞 7 🙂 69.97% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@MitchellAcoustics
Copy link
Owner Author

This is from a much earlier version of the package. Functions and approaaches used in this spectral slope work may be important to add later, but for now I'm keeping these out.

@MitchellAcoustics MitchellAcoustics marked this pull request as draft November 6, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MitchellAcoustics