Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user id to user table in db #355

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add user id to user table in db #355

merged 1 commit into from
Nov 13, 2024

Conversation

ChristopherSpelt
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt commented Nov 11, 2024 •
edited
Loading

Description

Adds user UUID from keycloak as pk in de user table.

Important implementation notes:

  • In migration files the user table first was dropped, and then was added again with a UUID type as pk due to the impossibilty of casting ints (the previous pk of the user table) to UUIDs (the new type of pk in of the user table).

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #351

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ChristopherSpelt ChristopherSpelt linked an issue Nov 11, 2024 that may be closed by this pull request
Create Users in AMT from OIDC ID token #351
Closed
@ChristopherSpelt ChristopherSpelt force-pushed the 351-create-users-in-amt-from-oidc-id-token branch 4 times, most recently from bfbfa35 to 27d5ccd Compare November 12, 2024 10:19
@ChristopherSpelt ChristopherSpelt marked this pull request as ready for review November 12, 2024 10:24
@ChristopherSpelt ChristopherSpelt requested a review from a team as a code owner November 12, 2024 10:24
uittenbroekrobbert
uittenbroekrobbert previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor remarks regarding comments.

@ChristopherSpelt ChristopherSpelt force-pushed the 351-create-users-in-amt-from-oidc-id-token branch from 27d5ccd to c247982 Compare November 13, 2024 09:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ChristopherSpelt ChristopherSpelt merged commit 41f1e7d into main Nov 13, 2024
14 checks passed
@ChristopherSpelt ChristopherSpelt deleted the 351-create-users-in-amt-from-oidc-id-token branch November 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Users in AMT from OIDC ID token
2 participants
@ChristopherSpelt @uittenbroekrobbert