Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project soft delete #344

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add project soft delete #344

merged 1 commit into from
Nov 11, 2024

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Nov 3, 2024 •
edited
Loading

Description

Resolves #324

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog linked an issue Nov 3, 2024 that may be closed by this pull request
Delete an algorithm system #324
Closed
@berrydenhartog berrydenhartog force-pushed the 324-delete-an-algorithm-system branch 7 times, most recently from 8aa3495 to 5964e54 Compare November 8, 2024 12:58
@berrydenhartog berrydenhartog marked this pull request as ready for review November 8, 2024 12:59
@berrydenhartog berrydenhartog requested a review from a team as a code owner November 8, 2024 12:59
@berrydenhartog berrydenhartog force-pushed the 324-delete-an-algorithm-system branch 3 times, most recently from 50c9f2b to f1689dc Compare November 8, 2024 15:16
@berrydenhartog berrydenhartog force-pushed the 324-delete-an-algorithm-system branch 2 times, most recently from 280630a to 1553757 Compare November 11, 2024 13:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
88.9% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

ChristopherSpelt
ChristopherSpelt approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berrydenhartog berrydenhartog merged commit 1bf364d into main Nov 11, 2024
13 of 14 checks passed
@berrydenhartog berrydenhartog deleted the 324-delete-an-algorithm-system branch November 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherSpelt ChristopherSpelt ChristopherSpelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete an algorithm system
2 participants
@berrydenhartog @ChristopherSpelt