Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra feedback on group by overview #340

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Extra feedback on group by overview #340

merged 1 commit into from
Oct 30, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Oct 30, 2024 •
edited
Loading

Description

Simplify count per group
When disabled make the chevron subtle gray
Correct Dutch translation
Better alignment of Algorithm systems in grouped by view

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner October 30, 2024 13:20
@laurensWe laurensWe changed the title Simplify count per group Extra feedback on group by overview Oct 30, 2024
uittenbroekrobbert
uittenbroekrobbert previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@laurensWe laurensWe merged commit 4773cc7 into main Oct 30, 2024
13 of 14 checks passed
@laurensWe laurensWe deleted the extra_feedback_group_by_view branch October 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurensWe @uittenbroekrobbert