Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fields editable #292

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Make fields editable #292

merged 1 commit into from
Oct 21, 2024

Conversation

anneschuth
Copy link
Member

@anneschuth anneschuth commented Oct 20, 2024 •
edited
Loading

Description

Make fields editable (some will be overwritten still, right after, because of mocking).

With this PR, fields can be made editable as follows:

{{ editable(project, "lifecycle") }}
{{ editable(project, "system_card.ai_act_profile.publication_category") }}
image

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@anneschuth anneschuth self-assigned this Oct 20, 2024
@anneschuth anneschuth force-pushed the feature/edit-fields branch 8 times, most recently from 9b12fee to 225e27b Compare October 20, 2024 18:15
@anneschuth anneschuth marked this pull request as ready for review October 20, 2024 18:21
@anneschuth anneschuth requested a review from a team as a code owner October 20, 2024 18:21
berrydenhartog
berrydenhartog previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChristopherSpelt
ChristopherSpelt previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ChristopherSpelt ChristopherSpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lgtm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

uittenbroekrobbert
uittenbroekrobbert approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@uittenbroekrobbert uittenbroekrobbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anneschuth anneschuth merged commit 5801578 into main Oct 21, 2024
14 checks passed
@anneschuth anneschuth deleted the feature/edit-fields branch October 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uittenbroekrobbert uittenbroekrobbert uittenbroekrobbert approved these changes

@ChristopherSpelt ChristopherSpelt ChristopherSpelt left review comments

@berrydenhartog berrydenhartog berrydenhartog left review comments

Assignees

@anneschuth anneschuth

Labels
None yet
Projects
👾 AI Validation Team Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anneschuth @berrydenhartog @ChristopherSpelt @uittenbroekrobbert