Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example systemcard for demo #273

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Conversation

ravimeijerrig
Copy link
Contributor

@ravimeijerrig ravimeijerrig commented Oct 15, 2024

Description

In this PR we:

  • Add a systemcard example usecase for the demo based on the WOZ-waarde bepaling van de gemeente Oirschot.

Considerations:

  • The systemcard is in Dutch, do we want that?
  • The links now include a name and a link, this needs to be changed in the schema too.

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@ravimeijerrig ravimeijerrig requested a review from a team as a code owner October 15, 2024 13:13
@ravimeijerrig ravimeijerrig linked an issue Oct 15, 2024 that may be closed by this pull request
berrydenhartog
berrydenhartog previously approved these changes Oct 16, 2024
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

laurensWe
laurensWe previously approved these changes Oct 16, 2024
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ChristopherSpelt ChristopherSpelt force-pushed the feature/add_example_usecase_for_demo branch from 6f21bf4 to 6c807c8 Compare October 16, 2024 09:05
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the widget :) LGTM

@laurensWe laurensWe merged commit 64a2143 into main Oct 16, 2024
14 checks passed
@laurensWe laurensWe deleted the feature/add_example_usecase_for_demo branch October 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move references from 'Algorithm details' to 'Info' tab Add demo use case systemcard
4 participants