Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chip with alert #272

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Replace chip with alert #272

merged 1 commit into from
Oct 16, 2024

Conversation

rubenrouwhof
Copy link
Contributor

Description

Proposal to replace chip with banner for the following reasons:

  • Alert is NLDS component
  • Better visible that it's a beta version
  • Looks cleaner

Link all GitHub issues fixed by this PR.
Make sure to first open an issue, get community approval and only then create Pull Request to resolve it.
All Pull Requests must have an issue attached to them

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@rubenrouwhof rubenrouwhof requested a review from a team as a code owner October 15, 2024 12:48
berrydenhartog
berrydenhartog previously approved these changes Oct 16, 2024
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 16, 2024

@berrydenhartog berrydenhartog merged commit 6ce91cd into main Oct 16, 2024
13 of 14 checks passed
@berrydenhartog berrydenhartog deleted the fix/beta-chip branch October 16, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants