Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile and landing page #267

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

berrydenhartog
Copy link
Member

@berrydenhartog berrydenhartog commented Oct 14, 2024

Description

This PR adds a profile and landing page. It also changes the header a bit. I added styles in the html for styling (i know this is bad practice)

Resolves #

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@berrydenhartog berrydenhartog requested a review from a team as a code owner October 14, 2024 13:07
@berrydenhartog berrydenhartog force-pushed the 999-create-profile-landing-page branch 2 times, most recently from ea2c02e to 46a9006 Compare October 14, 2024 13:13
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

Copy link
Member

@anneschuth anneschuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@berrydenhartog berrydenhartog merged commit 3e79f36 into main Oct 14, 2024
13 of 14 checks passed
@berrydenhartog berrydenhartog deleted the 999-create-profile-landing-page branch October 14, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants