adding 404 status_code

[mrrfly]

Fix Output For 404 Status Code

From This:

To This:

[Andrenzo17]

Hi @mrrfly Thanks for the Open PR.

Currently, Midtrans Php has not handled custom object errors. So that the error is more descriptive and the developer knows the error comes from the Midtrans API, that’s why we added “Midtrans API is returning API error. HTTP status code: ……….”

Could you more clarify, what is your concern to add this enhancement? does the exception object not useful enough?

Thank you

[mrrfly]

oke, simple.

How do I find transactions?

if i find and i found, status code is 200. and return an object.

Then, what if transaction is not found ?
Now, midtrans using exception object, it doesn't match.

That's why I turn it into an object if the transaction is not found and that will make it easier for the developer.

Maybe, you should check this issue: ##66

Thank's

[Andrenzo17]

Thanks for clarify.

Our concern if we only throw JSON it will be hard to debug, for example if merchant connect to multiple API and Midtrans library only throw JSON result. It wiil be difficult for merchant to find the error.

Yes, we have already checked the previous issue. Also we will put as our backlog mark as an enhancement to implement exception object can be like other library Midtrans which can expose API response.

Thank you

[mrrfly]

But this commit is only for 404 status code.
Not 5xx or whatever

[Andrenzo17]

The current implementation work as we expected. 404 transaction doesn't exist case is considered as API error, hence it is intended to throw Exception.

However we understand the concern that there is a need from your side to be able to access the raw API response JSON as object, instead of string of Exception. So the correct approach will be to throw Exception, but the exception should have a properties that expose the JSON as an object. So it will be more useful if you intend to implement try-catch. We will assess internally and add to backlog.

Thank you

[mrrfly]

Thank you for the explanation.
I will close this pull.

Thank's for the work 👍