Update workload-identity-federation-config-app-trust-managed-identity.md #1322
Conversation
Add note about the Microsoft Graph Bicep feature limitations that apply to the bicep sample.
|
@EvanSchallerer : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 55d1475:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/workload-id/workload-identity-federation-config-app-trust-managed-identity.md | Details |
docs/workload-id/workload-identity-federation-config-app-trust-managed-identity.md
- Line 139, Column 170: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/graph/templates/limitations#unsupported-deployment-features' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 139, Column 170: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/graph/templates/limitations#unsupported-deployment-features' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Remove locale in link.
|
Learn Build status updates of commit 825a787: 💡 Validation status: suggestions
docs/workload-id/workload-identity-federation-config-app-trust-managed-identity.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Disambiguate example application ID guid to avoid confusion with the managed identity guid.
|
Learn Build status updates of commit 255ec05: 💡 Validation status: suggestions
docs/workload-id/workload-identity-federation-config-app-trust-managed-identity.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
@cilwerner Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
docs/workload-id/workload-identity-federation-config-app-trust-managed-identity.md
Outdated
Show resolved
Hide resolved
| @@ -101,7 +101,7 @@ In this section, you'll configure a federated identity credential on an existing | |||
| Open a terminal in your preferred IDE and run the following command to create a federated identity credential on your app. Replace the GUID with the Object (principal) ID of the managed identity. | |||
|
|
|||
| ```CLI | |||
| az ad app federated-credential create --id 00001111-aaaa-2222-bbbb-3333cccc4444 --parameters credential.json | |||
| az ad app federated-credential create --id 11112222-bbbb-3333-cccc-4444dddd5555 --parameters credential.json | |||
There was a problem hiding this comment.
This should not be changed, this sample GUID is mentioned again in L113. Please revert.
| az ad app federated-credential create --id 11112222-bbbb-3333-cccc-4444dddd5555 --parameters credential.json | |
| az ad app federated-credential create --id 00001111-aaaa-2222-bbbb-3333cccc4444 --parameters credential.json |
There was a problem hiding this comment.
That is the reason I changed it, I believe the GUID on line 113 should be different. It's my understanding that the Object ID of the managed identity is different than the application ID which becomes confusing when this doc shows the same sample guid for both.
…-managed-identity.md Change link to MS Graph limitations doc to be relative per PR review suggestion. Co-authored-by: Chris Werner <[email protected]>
|
Learn Build status updates of commit f8a49b8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Add note about the Microsoft Graph Bicep feature limitations that apply to the bicep sample.
Also disambiguates the example GUID used for the application id from that used for the subject in order to avoid confusion.