Prepare for release 4.13

MichaelGrafnetter · Dec 20, 2023 · 8f10165 · 8f10165
1 parent d87acf5
commit 8f10165
Show file tree

Hide file tree

Showing 16 changed files with 43 additions and 30 deletions.
diff --git a/Documentation/CHANGELOG.md b/Documentation/CHANGELOG.md
@@ -5,6 +5,12 @@
 
 All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## [4.13] - 2023-12-20
+
+### Fixed
+
+- The [Set-LsaPolicyInformation](PowerShell/Set-LsaPolicyInformation.md#set-lsapolicyinformation) cmdlet now generates the [UNICODE_STRING](https://learn.microsoft.com/en-us/windows/win32/api/ntdef/ns-ntdef-_unicode_string) structure with the trailing null character, to improve compatibility with NETLOGON. This issue mainly affects the functionality of the [New-ADDBRestoreFromMediaScript](PowerShell/New-ADDBRestoreFromMediaScript.md#new-addbrestorefrommediascript) cmdlet. Thanks Christoffer Andersson for reporting this issue and sorry Microsoft support escalation engineers for the trouble this bug has caused.
+
 ## [4.12] - 2023-10-06
 
 ### Added
@@ -497,7 +503,8 @@ This is a [Chocolatey](https://chocolatey.org/packages/dsinternals-psmodule)-onl
 ## 1.0 - 2015-01-20
 Initial release!
 
-[Unreleased]: https://github.com/MichaelGrafnetter/DSInternals/compare/v4.12...HEAD
+[Unreleased]: https://github.com/MichaelGrafnetter/DSInternals/compare/v4.13...HEAD
+[4.13]: https://github.com/MichaelGrafnetter/DSInternals/compare/v4.12...v4.13
 [4.12]: https://github.com/MichaelGrafnetter/DSInternals/compare/v4.11...v4.12
 [4.11]: https://github.com/MichaelGrafnetter/DSInternals/compare/v4.10...v4.11
 [4.10]: https://github.com/MichaelGrafnetter/DSInternals/compare/v4.9...v4.10

diff --git a/Src/DSInternals.Common/DSInternals.Common.nuspec b/Src/DSInternals.Common/DSInternals.Common.nuspec
@@ -14,7 +14,7 @@
     <description>This package is shared between all other DSInternals packages. Its main features are Azure AD Graph API and ADSI clients for for retrieval of cryptographic material. It contains implementations of common hash functions used by Windows, including NT hash, LM hash and OrgId hash. It also contains methods for SysKey/BootKey retrieval.</description>
     <summary>This package is shared between all other DSInternals packages.</summary>
     <releaseNotes>
-- Added support for parsing AES SHA2 Kerbers keys.
+- Fixed a bug in LSA Policy modification.
     </releaseNotes>
     <copyright>Copyright (c) 2015-2023 Michael Grafnetter. All rights reserved.</copyright>
     <tags>ActiveDirectory Security AD AAD Identity Active Directory</tags>

diff --git a/Src/DSInternals.Common/Interop/UnicodeString.cs b/Src/DSInternals.Common/Interop/UnicodeString.cs
@@ -6,7 +6,7 @@ namespace DSInternals.Common.Interop
     /// <summary>
     /// The UnicodeString structure is used to define Unicode strings.
     /// </summary>
-    /// <see>http://msdn.microsoft.com/library/windows/hardware/ff564879.aspx</see>
+    /// <see>https://learn.microsoft.com/en-us/windows/win32/api/ntdef/ns-ntdef-_unicode_string</see>
     [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
     public struct UnicodeString
     {
@@ -31,14 +31,22 @@ public UnicodeString(string text)
             else
             {
                 this.Buffer = text;
+
                 // Length of the unicode string.
-                this.Length = this.MaximumLength = (ushort)(text.Length * UnicodeCharLength);
+                this.Length = (ushort)(text.Length * UnicodeCharLength);
+
+                // Length of the unicode string, including the trailing null character.
+                // Important: Some Windows components, including the Local Security Authority (LSA) do not behave properly if Length==MaximumLength.
+                this.MaximumLength = (ushort)(this.Length + UnicodeCharLength);
             }
         }
 
         /// <summary>
         /// The length, in bytes, of the string stored in Buffer.
         /// </summary>
+        /// <remarks>
+        /// If the string is null-terminated, Length does not include the trailing null character.
+        /// </remarks>
         public ushort Length;
 
         /// <summary>

diff --git a/Src/DSInternals.Common/Properties/AssemblyInfo.cs b/Src/DSInternals.Common/Properties/AssemblyInfo.cs
@@ -5,8 +5,8 @@
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("DSInternals Common Library")]
-[assembly: AssemblyVersion("4.12")]
-[assembly: AssemblyFileVersion("4.12")]
+[assembly: AssemblyVersion("4.13")]
+[assembly: AssemblyFileVersion("4.13")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]

diff --git a/Src/DSInternals.DataStore/DSInternals.DataStore.nuspec b/Src/DSInternals.DataStore/DSInternals.DataStore.nuspec
@@ -14,7 +14,7 @@
     <description>DSInternals DataStore is an advanced framework for offline ntds.dit file manipulation. It can be used to extract password hashes from Active Directory backups or to modify the sIDHistory and primaryGroupId attributes.</description>
     <summary>DSInternals DataStore is an advanced framework for offline ntds.dit file manipulation.</summary>
     <releaseNotes>
-- Support for Windows Server 2025 Insider Preview.
+- Updated dependency version.
     </releaseNotes>
     <copyright>Copyright (c) 2015-2023 Michael Grafnetter. All rights reserved.</copyright>
     <tags>ActiveDirectory Security NTDS AD Identity Active Directory</tags>

diff --git a/Src/DSInternals.DataStore/Properties/AssemblyInfo.cs b/Src/DSInternals.DataStore/Properties/AssemblyInfo.cs
@@ -5,8 +5,8 @@
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("DSInternals DataStore Library")]
-[assembly: AssemblyVersion("4.12")]
-[assembly: AssemblyFileVersion("4.12")]
+[assembly: AssemblyVersion("4.13")]
+[assembly: AssemblyFileVersion("4.13")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]

diff --git a/Src/DSInternals.PowerShell/Chocolatey/dsinternals-psmodule.nuspec b/Src/DSInternals.PowerShell/Chocolatey/dsinternals-psmodule.nuspec
@@ -3,7 +3,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
   <metadata>
     <id>DSInternals-PSModule</id>
-    <version>4.12</version>
+    <version>4.13</version>
     <packageSourceUrl>https://github.com/MichaelGrafnetter/DSInternals/tree/master/Src/DSInternals.PowerShell/Chocolatey</packageSourceUrl>
     <owners>MichaelGrafnetter</owners>
     <title>DSInternals PowerShell Module</title>
@@ -37,8 +37,7 @@ The DSInternals PowerShell Module has these main features:
 ## Disclaimer
 Features exposed through these tools are not supported by Microsoft. Improper use might cause irreversible damage to domain controllers or negatively impact domain security.</description>
     <releaseNotes>
-* Support for Windows Server 2025 Insider Preview.
-* Improved KDS Root Key selection algorithm.
+* Fixed a bug in LSA Policy modification.
     </releaseNotes>
     <dependencies>
       <!-- Windows Management Framework 3+. For OS prior to Windows 8 and Windows Server 2012. -->

diff --git a/Src/DSInternals.PowerShell/DSInternals.psd1 b/Src/DSInternals.PowerShell/DSInternals.psd1
@@ -8,7 +8,7 @@
 RootModule = 'DSInternals.Bootstrap.psm1'
 
 # Version number of this module.
-ModuleVersion = '4.12'
+ModuleVersion = '4.13'
 
 # Supported PSEditions
 # CompatiblePSEditions = 'Desktop'
@@ -143,8 +143,7 @@ PrivateData = @{
 
         # ReleaseNotes of this module
         ReleaseNotes = @"
-- Support for Windows Server 2025 Insider Preview.
-- Improved KDS Root Key selection algorithm.
+- Fixed a bug in LSA Policy modification.
 "@
     } # End of PSData hashtable
 

diff --git a/Src/DSInternals.PowerShell/Properties/AssemblyInfo.cs b/Src/DSInternals.PowerShell/Properties/AssemblyInfo.cs
@@ -5,8 +5,8 @@
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("DSInternals PowerShell Commands")]
-[assembly: AssemblyVersion("4.12")]
-[assembly: AssemblyFileVersion("4.12")]
+[assembly: AssemblyVersion("4.13")]
+[assembly: AssemblyFileVersion("4.13")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]

diff --git a/Src/DSInternals.Replication.Interop/AssemblyInfo.cpp b/Src/DSInternals.Replication.Interop/AssemblyInfo.cpp
@@ -14,7 +14,7 @@ using namespace System::Security::Permissions;
 //
 [assembly:AssemblyTitleAttribute(L"DSInternals Replication Interop Library")];
 // Note: Do not forget to change the version in version.rc files.
-[assembly:AssemblyVersionAttribute("4.12")];
+[assembly:AssemblyVersionAttribute("4.13")];
 [assembly:AssemblyDescriptionAttribute(L"")];
 [assembly:AssemblyConfigurationAttribute(L"")];
 [assembly:AssemblyCompanyAttribute(L"")];

diff --git a/Src/DSInternals.Replication.Interop/version.rc b/Src/DSInternals.Replication.Interop/version.rc
@@ -39,8 +39,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 4,12,0,0
- PRODUCTVERSION 4,12,0,0
+ FILEVERSION 4,13,0,0
+ PRODUCTVERSION 4,13,0,0
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -57,12 +57,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Michael Grafnetter"
             VALUE "FileDescription", "DSInternals Replication Interop Library"
-            VALUE "FileVersion", "4.12.0.0"
+            VALUE "FileVersion", "4.13.0.0"
             VALUE "InternalName", "DSInternals.Replication.Interop"
             VALUE "LegalCopyright", "Copyright � 2015-2023 Michael Grafnetter"
             VALUE "OriginalFilename", "DSInternals.Replication.Interop.dll"
             VALUE "ProductName", "DSInternals PowerShell Module"
-            VALUE "ProductVersion", "4.12.0.0"
+            VALUE "ProductVersion", "4.13.0.0"
         END
     END
     BLOCK "VarFileInfo"

diff --git a/Src/DSInternals.Replication.Model/Properties/AssemblyInfo.cs b/Src/DSInternals.Replication.Model/Properties/AssemblyInfo.cs
@@ -5,8 +5,8 @@
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("DSInternals Replication Data Model")]
-[assembly: AssemblyVersion("4.12")]
-[assembly: AssemblyFileVersion("4.12")]
+[assembly: AssemblyVersion("4.13")]
+[assembly: AssemblyFileVersion("4.13")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]

diff --git a/Src/DSInternals.Replication/DSInternals.Replication.nuspec b/Src/DSInternals.Replication/DSInternals.Replication.nuspec
@@ -14,7 +14,7 @@
     <description>DSInternals Replication implements a client for the Active Directory Replication Service Remote Protocol (DRS-R). It can be used to remotely extract password hashes from domain controllers.</description>
     <summary>DSInternals Replication implements a client for the Active Directory Replication Service Remote Protocol (DRS-R).</summary>
     <releaseNotes>
-- Support for Windows Server 2025 Insider Preview.
+- Updated dependency version.
     </releaseNotes>
     <copyright>Copyright (c) 2015-2023 Michael Grafnetter. All rights reserved.</copyright>
     <tags>ActiveDirectory Security RPC DRSR</tags>

diff --git a/Src/DSInternals.Replication/Properties/AssemblyInfo.cs b/Src/DSInternals.Replication/Properties/AssemblyInfo.cs
@@ -5,8 +5,8 @@
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("DSInternals Replication Library")]
-[assembly: AssemblyVersion("4.12")]
-[assembly: AssemblyFileVersion("4.12")]
+[assembly: AssemblyVersion("4.13")]
+[assembly: AssemblyFileVersion("4.13")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]

diff --git a/Src/DSInternals.SAM/DSInternals.SAM.nuspec b/Src/DSInternals.SAM/DSInternals.SAM.nuspec
@@ -14,7 +14,7 @@
     <description>DSInternals SAM implements a client for the Security Accounts Manager Remote Protocol (SAM-R) and Local Security Authority Remote Protocol(MS-LSAD or LSARPC). It can be used to import password hashes into Active Directory or to query and modify LSA Policy.</description>
     <summary>DSInternals SAM implements a client for SAM-R and MS-LSAD/LSARPC protocols.</summary>
     <releaseNotes>
-- Updated dependencies.
+- Fixed a bug in LSA Policy modification.
     </releaseNotes>
     <copyright>Copyright (c) 2015-2023 Michael Grafnetter. All rights reserved.</copyright>
     <tags>ActiveDirectory Security RPC SAMR LSARPC AD Identity Active Directory</tags>

diff --git a/Src/DSInternals.SAM/Properties/AssemblyInfo.cs b/Src/DSInternals.SAM/Properties/AssemblyInfo.cs
@@ -5,8 +5,8 @@
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
 [assembly: AssemblyTitle("DSInternals SAM Library")]
-[assembly: AssemblyVersion("4.12")]
-[assembly: AssemblyFileVersion("4.12")]
+[assembly: AssemblyVersion("4.13")]
+[assembly: AssemblyFileVersion("4.13")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]