Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed software "Network Tools" #7351

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

StephanStS
Copy link
Collaborator

@StephanStS StephanStS commented Jan 6, 2025

Removed iftop, IPTraf, Iperf, MTR-Tiny, nLoad, tcpdump from dietpi-software

Removed Software category "Network Tools"

Software Avahi Daemon moved to category "Advanced Networking"

Remark: Uninstall procedure from Iperf was missing (G_AGP iperf) in dietpi-software.

ToDo:

@StephanStS StephanStS added this to the v9.10 milestone Jan 6, 2025
@StephanStS StephanStS requested a review from MichaIng January 6, 2025 14:56
@StephanStS StephanStS self-assigned this Jan 6, 2025
CHANGELOG.txt Outdated Show resolved Hide resolved
@MichaIng
Copy link
Owner

MichaIng commented Jan 7, 2025

I would like to do the same with text editors and file managers. Or shall we split it into dedicated PRs?

Removed iftop, IPTraf, Iperf, MTR-Tiny, nLoad, tcpdump from dietpi-software
- Very rare usage.
- Software is removed, otherwise documentation would be needed.

Removed Software category "Network Tools"

Software Avahi moved to category "Advanced Networking"
@MichaIng MichaIng force-pushed the dev-StS_RemoveNetworkTools branch from eb93416 to 5477a1c Compare January 7, 2025 09:56
MichaIng and others added 2 commits January 7, 2025 17:07
- DietPi-Patches | Remove obsolete install states
- DietPi-Survey_report | Remove network tools from tracked software titles
Co-authored-by: MichaIng <[email protected]>
@StephanStS
Copy link
Collaborator Author

I would like to do the same with text editors and file managers. Or shall we split it into dedicated PRs?

I would propose dedicated PRs to do it step by step.

@StephanStS StephanStS merged commit f8229fb into dev Jan 7, 2025
2 checks passed
@StephanStS StephanStS deleted the dev-StS_RemoveNetworkTools branch January 7, 2025 14:25
@StephanStS
Copy link
Collaborator Author

I would like to do the same with text editors and file managers. Or shall we split it into dedicated PRs?

Survey statistics say (about 130 000 systems running) these counts of installations:

Text editors:

  • Emacs: 155
  • Jed: 97
  • Vim: 1254 (-> relevant)
  • Vim-Tiny: 322
  • Neovim: 397

File managers:

  • mc: 1628 (-> relevant)
  • ViFM: 81

In my opinion, we should not kick out Vim and mc. If we would kick out the remaining packages, the grouping "Text Editors" and "File Managers" would both consist of only one single package. What to do?

@MichaIng
Copy link
Owner

MichaIng commented Jan 8, 2025

And iftop has 763 reported installs. They are all relevant, but the point is that all dietpi-software does is installing (and removing) a single APT package, where it is just overkill to run that whole script for. It is important for users to know that DietPi is a regular Debian, where they can use APT to install any package. Having an install option in dietpi-software gives the impression it would do something more, or be the "correct" way to do it on DietPi, which is simply wrong on all those cases.

@StephanStS
Copy link
Collaborator Author

In my point of view, the user comfort by installing mc and Vim via well known dietpi-software is superior over the logic of "not installing simple apt install <...> packages".
(i.e. UX > "dietpi-software straightness")

@MichaIng
Copy link
Owner

MichaIng commented Jan 9, 2025

The question is where you want to draw the line: There are over 60k APT packages in Debian repo, many would deserve it like Midnight Commander or more, to be on the list, if you go by that. Same with a lot of Docker containers, which we explicitly chose to not offer via dietpi-software, for the very same reason. The only argument which keeps MC and Vim inside now, compared to them, is that they were inside before. But I prefer consistency over keeping things inconsistent, only because it already was like that.

Furthermore, this is all CLI/TUI tools, so people who use them, do use the console already, where using apt should be really no hurdle.

What we could do instead is adding some AUTO_INSTALL_APT_PACKAGES dietpi.txt setting to keep a way having those and any other APT packages installed automatically. This I wantesd since a while anyway 🙂.

But let's better discuss in #7354.

@StephanStS
Copy link
Collaborator Author

In my point of view, the user comfort by installing mc and Vim via well known dietpi-software is superior over the logic of "not installing simple apt install <...> packages".
(i.e. UX > "dietpi-software straightness")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants