-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BIP322 #1224
Implement BIP322 #1224
Conversation
3f1f0d5
to
d5fb75d
Compare
271d302
to
18e92e7
Compare
079dda4
to
8d92e07
Compare
8d92e07
to
9e27e4e
Compare
ack. I only reviewed the Key, Address and Bip322Signature and they look good to me. I would suggest to avoid try{}catch{} with empty catch because it makes the developers' live miserable, any bug is hidden and you will never understand why. On a side note, I am not sure we can use this in Wasabi. The Slip19 is based on a much earlier version of the bip322. Anyway, good job and thanks for this one @Kukks |
c757879
to
30448c0
Compare
Sadly not possible when parsing a witscript and a transaction without massive refactoring. The try/catch is however quite contained to parsing them. |
30448c0
to
ee1ad95
Compare
But cannot you know the type of the exception that would be thrown at least? |
No description provided.