Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use proper chain ID for signTypedData example #3013

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

FrederikBolding
Copy link
Member

When writing the signTypedData example I had based the code on some example code that hardcoded the chain ID. Instead we should use the current chain ID, so we can test the Snap on any chain.

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 14, 2025 14:48
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (493eedc) to head (8fc722a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3013   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         497      497           
  Lines       10896    10896           
  Branches     1674     1674           
=======================================
  Hits        10325    10325           
  Misses        571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 030ebee into main Jan 14, 2025
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-sign-typed-data-example branch January 14, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants