fix: Use proper chain ID for signTypedData example

MetaMask · Jan 14, 2025 · 8fc722a · 8fc722a
1 parent 493eedc
commit 8fc722a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/examples/packages/ethereum-provider/snap.manifest.json b/packages/examples/packages/ethereum-provider/snap.manifest.json
@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/snaps.git"
   },
   "source": {
-    "shasum": "T/7hin+Vhg0SdK8RxXvonPhkTRe/luTzGwqfWrH/8MQ=",
+    "shasum": "1QLc9RhVgpwxBu8FjPo5kZY61mpNoNAfkiAatq99Nc4=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",

diff --git a/packages/examples/packages/ethereum-provider/src/index.ts b/packages/examples/packages/ethereum-provider/src/index.ts
@@ -3,7 +3,12 @@ import {
   type OnRpcRequestHandler,
 } from '@metamask/snaps-sdk';
 import type { Hex } from '@metamask/utils';
-import { assert, stringToBytes, bytesToHex } from '@metamask/utils';
+import {
+  assert,
+  stringToBytes,
+  bytesToHex,
+  hexToNumber,
+} from '@metamask/utils';
 
 import type { PersonalSignParams, SignTypedDataParams } from './types';
 
@@ -107,6 +112,9 @@ async function personalSign(message: string, from: string) {
  * @see https://docs.metamask.io/wallet/concepts/signing-methods/#eth_signtypeddata_v4
  */
 async function signTypedData(message: string, from: string) {
+  const chainId = (await ethereum.request<string>({
+    method: 'eth_chainId',
+  })) as string;
   const signature = await ethereum.request<Hex>({
     method: 'eth_signTypedData_v4',
     params: [
@@ -160,7 +168,7 @@ async function signTypedData(message: string, from: string) {
         domain: {
           name: 'Ether Mail',
           version: '1',
-          chainId: 1,
+          chainId: hexToNumber(chainId),
           verifyingContract: '0xCcCCccccCCCCcCCCCCCcCcCccCcCCCcCcccccccC',
         },
         message: {