fix: stop polling on environment close

[bergeron]

Description

When the asset controllers start polling, they add their polling tokens to app state, keyed by the particular environment (popup vs fullscreen). But these polling tokens in app state were not being used during cleanup. This PR updates onEnvironmentTypeClosed to stop polling by those tokens.

Related issues

Manual testing steps

1. Open MM in fullscreen
2. Open MM popup
3. Close the popup
4. onEnvironmentTypeClosed should fire for the popup environment
5. Each polling token should be found and removed by one of the controllers

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [502c341]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1688 ± 67 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1432	1932	1696	135	65
		domContentLoaded	1424	1907	1662	133	64
		load	1432	1933	1688	139	67
		domInteractive	22	71	35	15	7
		backgroundConnect	7	77	26	19	9
		firstReactRender	15	102	46	32	15
		getState	5	90	32	30	14
		initialActions	0	0	0	0	0
		loadScripts	1038	1473	1254	125	60
		setupStore	6	77	17	21	10
		uiStartup	1648	2505	2059	260	125

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 223 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[danjm]

Could you add a unit test to verify that if it is called with a token that matches nothing, and then called with a token that does match, that unsubscribe is still successful? (Basically the 'should unsubscribe from the block tracker when called with a valid polling that was the only active pollingToken for a given networkClient' case, but with a call to the token that doesn't match

[danjm]

Only one suggestions