Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add background Redux slice as proxy for unflattened background state #29694

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from
Draft

refactor: Add background Redux slice as proxy for unflattened background state #29694

wants to merge 49 commits into from
+1,823 −613

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Jan 14, 2025 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift
Remove getFlatState method from ComposableObservableStore
52e818a
@MajorLift
Define types for metamask controller store fields
2a1fee2 
Define types for metamask controller stores
@MajorLift
Refactor MetamaskController store, memStore fields so that they…
3beda4d 
… are assigned composed controller state objects
@MajorLift
Update PatchStore class to conform with new state types
7143084
@MajorLift
Fix errors in MetamaskController store objects and types
28ca845
@MajorLift
Fix import paths
1f65a9f
@MajorLift
Simply PatchStore._generatePatches
899d855
@MajorLift
Update App{State,Metadata}Controller entries in store objects/types…
0eb33d7 
… to use state properties
@MajorLift
Move metamask-controllers types to shared directory
cb7eecd
@MajorLift
Remove NotificationController from MetamaskController and store
55fe737 
types
@MajorLift
Define BackgroundStateProxy type and replace `MemStoreControllersCo…
eea4c34 
…mposedState` usage
@MajorLift
Add eslint-disable for no-restricted-paths in types file
e3be201
@MajorLift
Optimize PatchStore to utilize controllerKey payload from `stateC…
601ce9e 
…hange` listener and avoid iterating through entire `metamask` slice for every background state update
@MajorLift
Fix sanitizeUIState with in property checks
6e54d6a
@MajorLift
Update and fix store, memStore
5f88de6
@MajorLift
Fix broken import for BalancesControllerState
2fc248a
@MajorLift
Convert ComposableObservableStore to TypeScript
622a096
@MajorLift
Fix all type errors in ComposableObservableStore
81e7756
@MajorLift
Allow PatchStore to handle top-level keys that aren't controllerKey…
f94f6a2 
…s for testing
@MajorLift
Fix implicit any in institutional store types
474efaa
@MajorLift
refactor: ComposableObservableStore takes a controller map as input…
1ccda39 
… and exposes their composed state via `.getState()`
@MajorLift
Fix BridgeControllerState import path
11831bc
@MajorLift
Remove ui/selectors/institutional/selectors.ts from diff
df7fa87
@MajorLift
Refactor sanitizeUIState so it can handle both the entire backgroun…
b74b346 
…d state and individual controller states as input
@MajorLift
Fix PatchStore to handle individual controller state only and not u…
d954084 
…pdates to the entire background state or top-level non-object properties of background state
@MajorLift
Fix Redux store actions updateMetamaskState, applyPatches to ensu…
578a736 
…re it can handle the unflattened background state
@MajorLift
Handle more edge cases in null check for controller.store.subscribe
1b62855
@MajorLift
Add variable assignment
50ba81a
@MajorLift
Convert ComposableObservableStore.test.{j,t}s
398bc7c
@MajorLift
Remove incorrect return type on sanitizeUIState
25cc18f
@MajorLift
Fix tests for PatchStore, sanitizeUiState
1eb1d70
@MajorLift
Fix tests for ComposableObservableStore
d93a318
@MajorLift
Linter fixes
bd57b45
@MajorLift
Temporary adjustment for Bridge{,Status}ControllerState types
83316a5
@MajorLift
Move initialMetamaskState into ui/ducks/metamask/constants.ts
312898f
@MajorLift
Remove TemporaryBackgroundState type and merge into `initialMetamas…
46d9d90 
…kState` for inference of `metamask` slice type
@MajorLift
Merge MetamaskState defined in metametrics-controller into `initi…
42607b3 
…alMetamaskState`
@MajorLift
Convert to TypeScript: combineReducer, metamask slice
ad32360
@MajorLift
Unflatten metamask slice and convert to TypeScript
161b882
@MajorLift
Replace CombinedBackgroundAndReduxState type with fixed `MetaMaskRe…
d05b4ec 
…duxState` type
@MajorLift
Remove unused import
fdcc097
@MajorLift
Unflatten SENTRY_UI_STATE object
6b66633
@MajorLift
Add missing PreferencesController.preferences properties to `SENTRY…
cce8b65 
…_BACKGROUND_STATE`
@MajorLift
Reduce diffs
578ccb6
@MajorLift
Rename MetamaskSliceState to MetaMaskSliceState
a06e900
@MajorLift
Unflatten metametrics-controller
5f65555
@MajorLift
Update type in updateMetamaskState
7af2f6a
@MajorLift
Rename: shared/types/{metamask,background}.ts
4a427ab
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MajorLift @metamaskbot