Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stick add team label version to commit hash #26540

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Aug 20, 2024

Description

Open in GitHub Codespaces

This PR is a one-line fix to stick the version of the add-team-label workflow to the commit hash instead of the branch name. This is particularly important due to the breaking change we are introducing to main, as giving write permissions for pull requests is now required as the workflow was reworked in MetaMask/github-tools#27.

Related issues

Fixes: MetaMask/github-tools#24

Manual testing steps

  1. Team label should be added automatically when PR is opened

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr requested a review from a team as a code owner August 20, 2024 14:28
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@itsyoboieltr itsyoboieltr changed the title fix: permissions for add team label fix: stick add team label to commit hash Aug 20, 2024
@itsyoboieltr itsyoboieltr changed the title fix: stick add team label to commit hash fix: stick add team label version to commit hash Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (da1ebc4) to head (cfed780).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26540   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1405     1405           
  Lines        49005    49005           
  Branches     13703    13703           
========================================
+ Hits         34283    34284    +1     
+ Misses       14722    14721    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@itsyoboieltr itsyoboieltr merged commit e95ba94 into develop Aug 20, 2024
77 of 78 checks passed
@itsyoboieltr itsyoboieltr deleted the update-add-team-label branch August 20, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 20, 2024
@itsyoboieltr itsyoboieltr restored the update-add-team-label branch August 20, 2024 17:06
@metamaskbot
Copy link
Collaborator

Builds ready [87a5c2e]
Page Load Metrics (71 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint72171992713
domContentLoaded42124672110
load47124712110
domInteractive96725136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add-team-label workflow is missing implementation
5 participants