Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team label reusable workflow #23

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

itsyoboieltr
Copy link
Contributor

Instead of copy-pasting the implementation of add-team-label to other repositories, such as metamask-extension and metamask-mobile, it should be possible to call the workflow directly from the github-tools repository, if we make it a reusable workflow. This is great, because if we make a change to the workflow in the github-tools repository, the changes propagate to other repositories as well.

More information about reusable workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows

This kind of aligns with MetaMask/metamask-extension#25509, but not exactly. The shared library would still be needed nevertheless, as this is only sharing the workflow definition, but not the scripts that are run during the workflow. The scripts still need to exist in all the repositories (for now). Ideally, we would make the shared library an npm package that can be installed in the different repositories to allow for the sharing of scripts.

Resolves: https://github.com/MetaMask/MetaMask-planning/issues/2760

@itsyoboieltr itsyoboieltr requested review from mcmire and a team July 19, 2024 14:10
@hjetpoluru hjetpoluru merged commit 7c10eb3 into main Jul 19, 2024
7 checks passed
@hjetpoluru hjetpoluru deleted the add-team-label-reusable-workflow branch July 19, 2024 18:07
@legobeat
Copy link

legobeat commented Jul 31, 2024

This kind of aligns with MetaMask/metamask-extension#25509, but not exactly. The shared library would still be needed nevertheless, as this is only sharing the workflow definition, but not the scripts that are run during the workflow. The scripts still need to exist in all the repositories (for now).

Why is this?

Ideally, we would make the shared library an npm package that can be installed in the different repositories to allow for the sharing of scripts.

Can we not simply inline the script into this repo?

@itsyoboieltr
Copy link
Contributor Author

We can! and now that we have this public repository for scripts like this, we should, as it is a much better solution 😄 @legobeat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants