Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

chore: aligning dependencies with the metamask-design-system #747

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Nov 8, 2024

Description

This PR aligns the dependency versions and configuration files (TypeScript, ESLint, Prettier) in the design-tokens repository with those used in the metamask-design-system monorepo, as part of the migration process. This alignment addresses compatibility issues and ensures that the configurations between the repositories are consistent, making future maintenance more straightforward.

Related issues

Fixes: #746

Manual testing steps

  1. Review dependency versions and configuration files (TypeScript, ESLint, Prettier) to ensure they are consistent with the metamask-design-system monorepo.
  2. Verify that there are no errors or compatibility issues introduced by these changes. e.g yarn lint yarn build

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues.
  • I've included manual testing steps.
  • I've included screenshots/recordings if applicable.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines).

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this Nov 8, 2024
Copy link

socket-security bot commented Nov 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jest/[email protected] None 0 21.6 kB simenb
npm/@jest/[email protected] unsafe +1 180 kB simenb
npm/@jest/[email protected] None 0 12.4 kB simenb
npm/@jest/[email protected] None 0 26.5 kB simenb
npm/@jest/[email protected] None 0 3.56 kB simenb
npm/@jest/[email protected] environment, unsafe 0 103 kB simenb
npm/@jest/[email protected] None 0 5.65 kB simenb
npm/@jest/[email protected] None 0 17.1 kB simenb
npm/@jest/[email protected] None 0 10.5 kB simenb
npm/@jest/[email protected] Transitive: filesystem +2 74.3 kB simenb
npm/@jest/[email protected] None 0 27.6 kB simenb
npm/@sinonjs/[email protected] eval 0 89.1 kB fatso83
npm/@storybook/[email protected] None 0 59.1 kB domyen, ghengeveld, jreinhold, ...8 more
npm/@storybook/[email protected] None 0 27 kB shilman
npm/@storybook/[email protected] None 0 259 kB shilman
npm/@storybook/[email protected] None 0 2.19 MB shilman
npm/@storybook/[email protected] None 0 16.6 kB shilman
npm/@storybook/[email protected] None 0 9.04 kB shilman
npm/@storybook/[email protected] None 0 129 kB domyen, ghengeveld, jreinhold, ...8 more
npm/@storybook/[email protected] None 0 18.9 kB domyen, ghengeveld, jreinhold, ...8 more
npm/@storybook/[email protected] None 0 32 kB shilman
npm/@storybook/[email protected] None 0 22.7 kB shilman
npm/@storybook/[email protected] None 0 9.65 kB shilman
npm/@storybook/[email protected] None 0 26.9 kB shilman
npm/@storybook/[email protected] environment, eval 0 604 kB shilman
npm/@storybook/[email protected] environment, eval, filesystem 0 457 kB shilman
npm/@storybook/[email protected] None 0 1.29 kB shilman
npm/@storybook/[email protected] Transitive: environment, network +2 19.5 MB shilman
npm/@storybook/[email protected] filesystem 0 10.4 kB shilman
npm/@storybook/[email protected] environment 0 218 kB shilman
npm/@storybook/[email protected] None 0 1.27 kB shilman
npm/@storybook/[email protected] None 0 1.29 kB shilman
npm/@storybook/[email protected] None 0 10.1 kB shilman
npm/@storybook/[email protected] None 0 12.4 kB shilman
npm/@storybook/[email protected] environment 0 924 kB shilman
npm/@storybook/[email protected] environment, eval 0 1.52 MB shilman
npm/@storybook/[email protected] None 0 1.58 kB shilman
npm/@tootallnate/[email protected] None 0 4.08 kB tootallnate
npm/@types/[email protected] None 0 71.4 kB types
npm/@types/[email protected] None 0 53 kB types
npm/[email protected] None 0 10.4 kB jeffcarp
npm/[email protected] None +1 1.22 MB timothygu
npm/[email protected] None 0 100 kB marijn
npm/[email protected] None 0 27.4 kB alexindigo
npm/[email protected] environment 0 14.4 kB simenb
npm/[email protected] None 0 13.7 kB simenb
npm/[email protected] None 0 2.73 kB simenb
npm/[email protected] None 0 3.52 kB kumavis
npm/[email protected] None 0 11.5 kB alexindigo
npm/[email protected] None 0 48.7 kB nv
npm/[email protected] None +1 225 kB jon.sakas
npm/[email protected] None +1 98.8 kB domenic
npm/[email protected] None 0 283 kB mikemcl
npm/[email protected] None 0 8.02 kB apechimp
npm/[email protected] None 0 53 kB simenb
npm/[email protected] None +1 35.5 kB domenic
npm/[email protected] None 0 35.5 kB sindresorhus
npm/[email protected] None 0 109 kB michaelficarra
npm/[email protected] eval 0 172 kB simenb
npm/[email protected] filesystem, network 0 31 kB ljharb
npm/[email protected] None 0 11.5 kB domenic
npm/[email protected] None 0 3.92 kB mathias
npm/[email protected] None 0 4.41 kB hughsk
npm/[email protected] environment 0 15.1 kB simenb
npm/[email protected] eval 0 78.1 kB simenb
npm/[email protected] Transitive: environment, filesystem +3 502 kB simenb
npm/[email protected] Transitive: filesystem +1 167 kB simenb
npm/[email protected] eval 0 85.2 kB simenb
npm/[email protected] None 0 9.08 kB simenb
npm/[email protected] None 0 39.9 kB simenb
npm/[email protected] None 0 8.1 kB simenb
npm/[email protected] unsafe 0 7.32 kB simenb
npm/[email protected] None 0 3.81 kB simenb
npm/[email protected] environment, filesystem, shell 0 135 kB simenb
npm/[email protected] eval 0 137 kB simenb
npm/[email protected] unsafe 0 5.75 kB simenb
npm/[email protected] None 0 28.6 kB simenb
npm/[email protected] eval 0 18.1 kB simenb
npm/[email protected] None 0 39.1 kB simenb
npm/[email protected] None 0 3.37 kB simenb
npm/[email protected] None 0 9.11 kB simenb
npm/[email protected] environment, unsafe 0 52.9 kB simenb
npm/[email protected] environment 0 30.8 kB simenb
npm/[email protected] unsafe +1 85.9 kB simenb
npm/[email protected] unsafe 0 7.12 kB simenb
npm/[email protected] eval 0 93.2 kB simenb
npm/[email protected] environment 0 41.9 kB simenb
npm/[email protected] None 0 32 kB simenb
npm/[email protected] None 0 26.7 kB simenb
npm/[email protected] environment, shell +1 90.3 kB simenb
npm/[email protected] None 0 4.74 kB simenb
npm/[email protected] eval, filesystem, network, shell, unsafe +3 2.85 MB domenic
npm/[email protected] None 0 206 kB dougwilson
npm/[email protected] None 0 18.3 kB dougwilson
npm/[email protected] None 0 81.6 kB diego
npm/[email protected] None 0 331 kB inikulin
npm/[email protected] None 0 532 kB lupomontero
npm/[email protected] None 0 6.96 kB lpinca
npm/[email protected] None 0 8.56 kB 3rdeden
npm/[email protected] None 0 164 kB lddubeau
npm/[email protected] filesystem 0 85.2 kB linusu
npm/[email protected] None 0 22.2 kB shilman
npm/[email protected] None 0 57.1 kB joris-van-der-wel
npm/[email protected] None 0 9.14 kB throat-bot
npm/[email protected] None +1 117 kB ccasey
npm/[email protected] None 0 210 kB timothygu
npm/[email protected] environment, filesystem, unsafe 0 260 kB kul
npm/[email protected] None 0 8.84 kB feross
npm/[email protected] None 0 40.6 MB typescript-bot
npm/[email protected] None 0 63 kB swaagie
npm/[email protected] filesystem, unsafe Transitive: network +3 287 kB oss-bot
npm/[email protected] None 0 16.8 kB timothygu
npm/[email protected] None 0 18 kB domenic
npm/[email protected] None 0 25.9 kB domenic
npm/[email protected] None +1 348 kB domenic
npm/[email protected] None 0 16.2 kB domenic
npm/[email protected] network 0 122 kB lpinca
npm/[email protected] None 0 23 kB domenic
npm/[email protected] None 0 59 kB lddubeau

🚮 Removed packages: npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@sinclair/[email protected], npm/@sinonjs/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Nov 8, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/@sinonjs/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/@jest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@tootallnate/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@georgewrmarshall
Copy link
Collaborator Author

@SocketSecurity ignore-all

  • Acceptable risk as we will be protected against supply chain attack by lavamoat
Screenshot 2024-11-08 at 1 39 53 PM Screenshot 2024-11-08 at 1 39 59 PM

@georgewrmarshall georgewrmarshall marked this pull request as ready for review November 8, 2024 21:40
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 8, 2024 21:40
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Nov 8, 2024
@georgewrmarshall
Copy link
Collaborator Author

As we are in the process of migrating we will not fix the announce storybook job

Screenshot 2024-11-08 at 1 43 59 PM

@georgewrmarshall georgewrmarshall merged commit d228d35 into main Nov 8, 2024
18 of 19 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/746/align-dependencies branch November 8, 2024 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align dependency versions and TypeScript, ESLint, Prettier configurations with the metamask module template
2 participants