Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/289.0.0 #5199

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Release/289.0.0 #5199

merged 1 commit into from
Jan 27, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

Explanation

Bumps @metamask/notification-services-controller from 0.16.0 to 0.17.0

References

Changelog

### Changed

- **BREAKING:** Bump depenency `firebase` from `^10.11.0` to `^11.2.0` ([#5196](https://github.com/MetaMask/core/pull/5196))

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners January 27, 2025 13:36
@@ -44,12 +50,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [0.12.1]

### Uncategorized
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog update was left uncategorised, updated this.

NOTE - is it possible for us to add this as part of the changelog validation/linting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, would need to dig into auto-changelog to determine if this is an available setting or if it would need to be a custom rule.

@Prithpal-Sooriya Prithpal-Sooriya merged commit 69b50e9 into main Jan 27, 2025
127 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the release/289.0.0 branch January 27, 2025 13:43

### Changed

- **BREAKING:** Bump depenency `firebase` from `^10.11.0` to `^11.2.0` ([#5196](https://github.com/MetaMask/core/pull/5196))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depenency -> dependency 🤦🏾

I will update this on the next notifications release (idk why my spellcheck didn't catch this).

zone-live pushed a commit that referenced this pull request Jan 27, 2025
## Explanation

Bumps `@metamask/notification-services-controller` from `0.16.0` to
`0.17.0`

## References

## Changelog

```
### Changed

- **BREAKING:** Bump depenency `firebase` from `^10.11.0` to `^11.2.0` ([#5196](#5196))
```

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants