Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax switch-exhaustiveness-check lint rule #5157

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Jan 15, 2025

Explanation

The default behavior for this rule enforces that a switch statement handle all possible values that the given variable could be, including type unions. This rule seems to be acting differently in different environments, especially CI, preventing developers from merging PRs. We could disable this rule entirely, but let's try relaxing it a bit to see if that improves the situation.

References

Changelog

(N/A; developer-only change)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

The default behavior for this rule enforces that a switch statement
handle all possible values that the given variable could be, including
type unions. This rule seems to be acting differently in different
environments, especially CI, preventing developers from merging PRs. We
could disable this rule entirely, but let's try relaxing it a bit to see
if that improves the situation.
@mcmire mcmire marked this pull request as ready for review January 15, 2025 18:56
@mcmire mcmire merged commit f92d7a3 into main Jan 15, 2025
118 checks passed
@mcmire mcmire deleted the relax-switch-exhaustiveness-check branch January 15, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants