Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SOL-46 adds the multichain transactions controller package #5133
base: main
Are you sure you want to change the base?
feat: SOL-46 adds the multichain transactions controller package #5133
Changes from 9 commits
e7cfce4
a0a03ce
f68e12e
4d8d109
ff896e3
cab9924
0fd57bd
c6d653a
7f5e254
a56bb7d
dd9cd07
0f81e04
70a01da
f366a9a
40826b1
1573d85
c21c749
f2ed82a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on hitting 100% test coverage from the start? When coverage is lower than 100%, it is a bit frustrating because it means if coverage drops in the future, you have to sort through the noise and find which file caused the drop. If we start out at 100, then we never run into that problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be a peer dependency? I notice that this controller talks to SnapsController via the messenger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in
dependencies
? I notice that we import this package directly inMultichainTransactionsController
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a peer dependency? I notice that we only use this controller in tests.