Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if image starts with 'ipfs://', the return value should be string type #4985

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

GinMu
Copy link

@GinMu GinMu commented Nov 27, 2024

Explanation

return promise value if image starts with 'ipfs://' at ERC721Standard.ts

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@GinMu GinMu requested a review from a team as a code owner November 27, 2024 08:22
@GinMu GinMu changed the title fix: return promise value if image starts with 'ipfs://' fix: if image starts with 'ipfs://', the return value should be string type Nov 27, 2024
@GinMu GinMu requested a review from a team as a code owner December 6, 2024 01:37
@mcmire
Copy link
Contributor

mcmire commented Dec 9, 2024

Hi @GinMu, thanks for submitting this PR. Glancing at the code there does seem to be a bug with getDetails in the case you highlighted.

It would be good to have a test which confirms the bugfix and then we can merge this. If you'd like to add this then that would be great, but otherwise we could do that. That's the only blocker I can see for this PR.

@mcmire mcmire added the bug Something isn't working label Dec 9, 2024
@GinMu
Copy link
Author

GinMu commented Dec 10, 2024

Hi @mcmire , have added test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants