-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SIP-12 with multiple resolutions & optimization #116
Conversation
…ls, let a snap identify the TLDs it supports
@hmalik88 We've put this in the backlog for now. Please update the group on the status when you return. Thank you! |
@kenhkan this needs further review, I responded to Frederik's comments. |
Hey, a DM from another MMer reminded me that I owe you review over on the CASA side! Is work continuing on this? where can i be helpful? Quick question: how does this work for SUBDOMAINS? could |
Hmm to get a subdomain working you can technically do I've paused work on the CAIP, I have to re-evaluate it's need in the future (domain lookup w/o that spec is fine in MM and I don't think anyone else in the space is thinking about this problem in depth yet 😄) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d10d902
SIP-12 is updated to allow for multiple resolutions across different protocols. Snaps can also now identify the TLDs they support.
Note: In the future, the protocol string type will be further narrowed to a CAIP resolution protocol identifier. See ChainAgnostic/CAIPs#253