Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker fix #17

Merged
merged 1 commit into from
Oct 16, 2024
Merged

docker fix #17

merged 1 commit into from
Oct 16, 2024

Conversation

SetoKaiba
Copy link

@Larvan2 Could you please merge this and have a try. It seems that I add the ":latest" by mistake.
And it only modify the docker publish process. It doesn't modify the original build process.

@SetoKaiba
Copy link
Author

SetoKaiba commented Oct 16, 2024

@Larvan2 I tested with it with my repo. It's working.
https://github.com/SetoKaiba/subconverter/actions/runs/11364672943

@SetoKaiba SetoKaiba mentioned this pull request Oct 16, 2024
@Larvan2 Larvan2 merged commit 26fcd54 into MetaCubeX:master Oct 16, 2024
6 of 9 checks passed
@Larvan2
Copy link

Larvan2 commented Oct 16, 2024

Problem still.

No warry, since we haven't maintained this repo for a long time, maybe there are some other things cause this issue.

Perhaps someday we will fix this when someone available.

@SetoKaiba
Copy link
Author

SetoKaiba commented Oct 16, 2024

Problem still.

No warry, since we haven't maintained this repo for a long time, maybe there are some other things cause this issue.

Perhaps someday we will fix this when someone available.

I fixed the docker.yml build only. I didn't fix the build.yml.

https://github.com/MetaCubeX/subconverter/actions/runs/11365668185
You should check this docker.yml github action.
Maybe you should check this after the 2 arm build actions and the merge action are finished.

https://github.com/MetaCubeX/subconverter/actions/runs/11365668189
This build.yml is not modified. So it will fail.

And also, you can check my repo maste branch.
https://github.com/SetoKaiba/subconverter
The only difference is the REGISTRY_IMAGE env variable.

And the docker image ghcr.io/SetoKaiba/subconverter:lastest is succssfully built.
I tested it.
You can just try docker image pull ghcr.io/setokaiba/subconverter:latest.

Anyway, I can use my own image temporarily. I created the PR in case that anyone else encountering the UUID case issue.
Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants