-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sckan 226 #202
Feature/sckan 226 #202
Conversation
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/cs_ingestion_services.py
Outdated
Show resolved
Hide resolved
While testing this I noticed that Notes are created in CET timezone but the frontend is displaying it in my system timezone: |
@zsinnema can you re-review this without considering what we are still discussing in https://metacell.atlassian.net/browse/SCKAN-248? |
Closes https://metacell.atlassian.net/browse/SCKAN-226
The following algorithm used was not tested and most likely will behave incorrectly for cases:
We need to see examples of how neurondm models those.
There are also cases where I can't get from the axioms the type of entity we are traversing in the partial order. For those cases I'm skipping the population and logging an error message. Again here I would need clarification from the neurondm team.
I did some local testing with mmset examples like:
Confirm that new statements are ingested ✅
Confirm that existent statements are updated when there are changes, a note is created and the previous notes are kept ✅
Confirm that existent statements are not updated when there are no changes ✅
Confirm that the ingestion is rolled back if any error occurs ✅
Confirm that erro_log.csv and success_log.csv are created ✅
Confirm upstream invalidation ✅ :
(invalid per se)
(invalid because of forward connection - multiple cases)
(invalid per se and also because of non-direct dependencies )