forked from google/neuroglancer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/high resolution screenshot #37
Open
seankmartin
wants to merge
126
commits into
master
Choose a base branch
from
feature/high-resolution-screenshot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no functional changes though
seankmartin
commented
Aug 30, 2024
feat(python): support resolution scale factor in CLI
Feature/na 356 Screenshot dialog UI
filippomc
reviewed
Nov 18, 2024
filippomc
reviewed
Nov 18, 2024
…anel and layer resolution metadata
…r if trying to close during screenshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature goal:
Support taking cropped screenshots from neuroglancer of only the data panels. Support taking these at x1, x2, or x4 scale.
In x2 and x4 scale, the canvas is resized. This means that 2D panels kind of "zoom out" to support the extra pixels. 3D panels on the other hand keep their view fixed, but have more pixels in the framebuffer.
Overall idea of files/classes:
ScreenshotHandler
is what actually interacts with the data to try and grab screenshot data, and repeatedly grab statistics while this is loading.ScreenshotManager
interacts with the display context to start theScreenshotHandler
process. It also receives information from theScreenshotHandler
and passes this on to the screenshot UI menu when appropriate. It saves the file when complete, and stops screenshots automatically if they hang.ScreenshotDialog
handles the user input to trigger actions in theScreenshotManager
, and shows updates from theScreenshotManager
to the user.