Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDE-78 Output CSV from creating an empty template not working as expected #52

Merged
merged 2 commits into from
May 3, 2024
Merged

CDE-78 Output CSV from creating an empty template not working as expected #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cca0c7
CDE-78 unnecessary code deleted
Aiga115 May 2, 2024
032383c
CDE-78 lint issue has been resolved
Aiga115 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions lib/contexts/data/DataContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const DataContextProvider = ({
datasetSample,
datasetMapping: rawDatasetMapping,
additionalDatasetMappings: rawAdditionalDatasetMappings = [],
headerIndexes: providedHeaderIndexes = defaultHeaderIndexes,
headerIndexes: providedHeaderIndexes,
collections: rawCollections,
config,
name,
Expand All @@ -41,16 +41,12 @@ export const DataContextProvider = ({

// Defines the mapping of the mandatory columns in the dataset mapping file
const headerIndexes = useMemo(() => {
// If the dataset mapping is not provided or has no data we use the default header indexes
if (!rawDatasetMapping || rawDatasetMapping.length === 0) {
return defaultHeaderIndexes;
}
// Merge providedHeaderIndexes with defaultHeaderIndexes if rawDatasetMapping is valid
return {
...defaultHeaderIndexes,
...providedHeaderIndexes
};
}, [providedHeaderIndexes, rawDatasetMapping]);
}, [providedHeaderIndexes]);

// validate dataset sample
const isDatasetInvalid = useMemo(() => {
Expand Down