CDE-73 tutorial responsivness improvement #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #CDE-73
Problem: tutorial responsivness improvement
Solution:
So react-joyride makes it already possible for tooltip to be responsible by changing its placement property, the problem is, it does that for the whole screen not for modal window that we are using
That's why I think we need to change placement property to be set to one of the properties (top | left | right | bottom) so tooltip can always stays there.
Also changed overflow of dialog mui to be hidden as when we shrink the window the sidebar also gets shrinked which is wrong, but content is still scrollable as home page content is set to be scrollable