Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDE-66 Preview missing functionalities #32

Merged
merged 3 commits into from
Mar 27, 2024
Merged

CDE-66 Preview missing functionalities #32

merged 3 commits into from
Mar 27, 2024

Conversation

Aiga115
Copy link
Contributor

@Aiga115 Aiga115 commented Mar 15, 2024

Issue #CDE-66
Problem: Preview missing functionalities
Solution:
Fix chip ui misalignment, add icon functionality

Recording.2024-03-11.123148.mp4

Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the misalignment between chips and table:

image

@Aiga115
Copy link
Contributor Author

Aiga115 commented Mar 18, 2024

I still see the misalignment between chips and table:

image

Sorry @afonsobspinto I don't see any misalignment between table and chips, like even the parent box of each chip has fixed height

@Aiga115 Aiga115 closed this Mar 18, 2024
@Aiga115 Aiga115 reopened this Mar 18, 2024
@afonsobspinto
Copy link
Member

Sorry @afonsobspinto I don't see any misalignment between table and chips, like even the parent box of each chip has fixed height

@Aiga115 I still see the misalignment. I'm adding @ddelpiano as reviewer to see what he experiences.

Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change the text 'No mapping yet' to 'Header not mapped'
  • make the chips part of the table, so just add a row on top where in each cell you place the chip, no border and white background, this should solve the entire alignment issue.

Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ddelpiano ddelpiano merged commit aa7d7ef into develop Mar 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants