-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDE-66 Preview missing functionalities #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @afonsobspinto I don't see any misalignment between table and chips, like even the parent box of each chip has fixed height |
@Aiga115 I still see the misalignment. I'm adding @ddelpiano as reviewer to see what he experiences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- change the text 'No mapping yet' to 'Header not mapped'
- make the chips part of the table, so just add a row on top where in each cell you place the chip, no border and white background, this should solve the entire alignment issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Issue #CDE-66
Problem: Preview missing functionalities
Solution:
Fix chip ui misalignment, add icon functionality
Recording.2024-03-11.123148.mp4