CDE-61 Filter input text in the mapping step to be connected to the data #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsinnema
reviewed
Mar 4, 2024
|
|
||
| const handleFiltersClose = () => { | ||
| setAnchorEl(null); | ||
| onChange() | ||
| // onChange(searchString) |
There was a problem hiding this comment.
@Aiga115 are you sure you want to comment this out? If so then please remove it from the code. The history is in Git
afonsobspinto
approved these changes
Mar 4, 2024
| @@ -0,0 +1,15 @@ | |||
| import { useEffect, useState } from 'react'; | |||
|
|
|||
| export const useDebounce = <T>(value: T, delay = 500) => { | |||
There was a problem hiding this comment.
thought: MUI has its own debounce hook: https://github.com/mui/material-ui/blob/e93d4aced02e17db28e0438eb9513dab18dc3878/packages/mui-utils/src/debounce/debounce.ts#L7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #CDE-61
Problem: Filter input text in the mapping step to be connected to the data
Solution:
Created a seperate hook that debounces the search input, then when debounce value changes we handle filtering
CDE.Demo.App.-.Google.Chrome.2024-02-29.15-15-45.mp4