Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cde 40 #20

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Feature/cde 40 #20

merged 16 commits into from
Feb 21, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Feb 20, 2024

closes https://metacell.atlassian.net/browse/CDE-40

  • Renames headerMapping prop to headerIndexes
  • Adds example collection to example application
  • Creates a mapper, as part of the lib, to transform elastic search hits into Option objects to the best of my knowledge. This mapper can be imported by users of the lib, or they can create their own mapping.
  • Connects collections step (suggested collection is set to the first collection provided in the init)
  • Connects CDE selection
  • Replaces the Entity model with a simpler string[ ]
  • Transforms context collections from an array to a dictionary for faster look-ups
  • When applicable, moves related components to a common folder (mapping, suggestions)
  • Starts customMappingDropdown refactoring to make it more generic, less dense and without hard-coded instructions (still unfinished, should be continued in a future task when we address the custom data fields).
  • Renames {Number}Step components to {StepName}Step component
  • Splits helper functions into different categories (getters, mappers, utils)
  • Creates reverse proxy to allow example query to interlex

Important considerations:

  • Example query to interlex requires a key. The key is created upon register on interlex. As of right now, the key is accessible in the codebase, as accepted while in a conversation with @ddelpiano .
  • Direct requests from the client to interlex are blocked by CORS (thus the need for the reverse-proxy)
  • Not all CDE's have preciseAbbreviation. The plan was to use that attribute to uniquely identify an entity (CDE or CustomDictionaryField). For now I'm using an hash of the title as preciseAbbreviation but I'm afraid that's not good enough.
  • Connect CDE mapping already present in the file provided

To address in other cards:

2024-02-20.15-34-16.mp4

Copy link
Collaborator

@zsinnema zsinnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afonsobspinto nice work! just one critical change required

vite.config.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@zsinnema zsinnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zsinnema zsinnema merged commit e55b87f into develop Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants