Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDE-58 Replace checkboxes in suggestion with radio button #19

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

Aiga115
Copy link
Contributor

@Aiga115 Aiga115 commented Feb 15, 2024

Issue #CDE-58
Problem: Replace checkboxes in suggestion with radio button
Solution:
Replaced checkboxes with radio buttons on suggestion step and replaced Radio with StyledRadio component on collection step
https://github.com/MetaCell/cde-mapper/assets/67194168/1021574c-361d-4aba-b5fb-42b05d7130e5

borderRadius: '50%',
width: 16,
height: 16,
backgroundColor: '#fff',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aiga115 could you please add color variables here instead of hardcoded ones

Copy link
Contributor

@vidhya-metacell vidhya-metacell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aiga115 could you please fix the gap between the radio and the arrow
Screen Shot 2024-02-15 at 7 18 50 PM
Screen Shot 2024-02-15 at 7 18 57 PM

Copy link
Contributor

@vidhya-metacell vidhya-metacell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aiga115 looks good
@zsinnema this can be merged

@zsinnema zsinnema merged commit 4e8c053 into develop Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants