Feature/cele 27 Layout manager wrapper component #9
Conversation
vidhya-metacell
commented
May 28, 2024
vidhya-metacell
commented
There was a problem hiding this comment.
Thanks for the PR @vidhya-metacell ! All looks good to me. There is only a small issue while compiling the project, almost nothing, either some default value missing, or the parameters of a component to declare as optional and it should be perfect like this :)
| @@ -5,7 +5,7 @@ import { useState } from "react"; | |||
|
|
|||
| const { white, brand600, gray100 } = vars; | |||
|
|
|||
| const CustomSwitch = () => { | |||
| const CustomSwitch = ({width, height, thumbDimension, checkedPosition}) => { | |||
There was a problem hiding this comment.
As the signature of the component changed, the new parameters should be also added when it is used in this component (here).
I can see that the parameter are kind of optional, so to not modify the CustomListItem component to add the parameters, another solution would be to define default values, or an interface stating that the fields are optional :)
There was a problem hiding this comment.
Hey @aranega , thanks for the suggestion. It makes sense. I have made the changes.
