Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cele 32 #8

Merged
merged 51 commits into from
Jul 17, 2024
Merged

Feature/cele 32 #8

merged 51 commits into from
Jul 17, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented May 27, 2024

Closes first iteration of https://metacell.atlassian.net/browse/CELE-32

  • Connect start from template button

  • Render graph with cytoscape and connect it to React context

  • Adds legend and menu prototypes

  • Adds different layout options

  • Adds different coloring options

  • Adds show connected option and show connected as individual cells

  • Removes placeholder left and right components

  • Changes workspace model to store a record of neuronID-> neuron for all the available neurons of the workspace (this includes all neurons existent in all the active datasets). This is required because /api/connections doesn't provide all the information necessary for the 'connected' neurons. The original nemanode code fetches all neuron information from all the datasets in the beginning of the application.

  • Adds "/api/connections" endpoint (not yet equivalent to the original nemanode endpoint due to different threshold strategiess)

On review please have a look at the following questions:
https://metacell.atlassian.net/browse/CELE-32?focusedCommentId=14503

2024-05-27.09-22-22.mp4

@afonsobspinto afonsobspinto marked this pull request as ready for review May 27, 2024 08:39
@afonsobspinto afonsobspinto requested a review from aranega May 27, 2024 08:39
@afonsobspinto afonsobspinto marked this pull request as ready for review July 15, 2024 22:56
@afonsobspinto afonsobspinto requested a review from aranega July 15, 2024 22:57
@afonsobspinto afonsobspinto marked this pull request as draft July 15, 2024 22:58
@afonsobspinto afonsobspinto removed the request for review from aranega July 15, 2024 22:58
@afonsobspinto afonsobspinto marked this pull request as ready for review July 15, 2024 23:19
@afonsobspinto afonsobspinto requested a review from aranega July 15, 2024 23:19
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR 🙏! All the code looks good to me, I'll test it quickly tomorrow and I'll merge it quickly 👌

@afonsobspinto afonsobspinto requested a review from aranega July 16, 2024 17:05
@aranega aranega merged commit a3f8314 into develop Jul 17, 2024
4 checks passed
@aranega aranega deleted the feature/CELE-32 branch July 17, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants