Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#108 update the ambientLight color #65

Merged
merged 1 commit into from
Oct 18, 2024
Merged

#108 update the ambientLight color #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions applications/visualizer/frontend/src/components/viewers/ThreeD/ThreeDViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {
CAMERA_FOV,
CAMERA_NEAR,
CAMERA_POSITION,
LIGHT_1_COLOR,
LIGHT_2_COLOR,
LIGHT_2_POSITION,
LIGHT_SCENE_BACKGROUND,
Expand Down Expand Up @@ -101,7 +100,7 @@ function ThreeDViewer() {
/>
<CameraControls ref={cameraControlRef} />

<ambientLight color={LIGHT_1_COLOR} />
<ambientLight color={"0x404040"} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I think it would make more sense to change the value of LIGHT_1_COLOR

<directionalLight color={LIGHT_2_COLOR} position={LIGHT_2_POSITION} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we need the directional light?


<Gizmo />
Expand Down