#75 Connect the colour picker to the context neuron data #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salam-Dalloul
commented
Oct 2, 2024
Salam-Dalloul
commented
aranega
requested changes
Oct 2, 2024
applications/visualizer/frontend/src/components/ViewerContainer/CustomListItem.tsx
Outdated
Show resolved
Hide resolved
…uron list items to put the correct default value
aranega
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Thank a lot for the changes 🙏 @Salam-Dalloul all looks super good!
| id: neuron, | ||
| label: neuron, | ||
| checked: Object.values(visibility).every((e) => e === undefined || e.visibility === Visibility.Visible), | ||
| color: visibility[ViewerType.ThreeD]?.color || visibility[ViewerType.EM]?.color || "#000000", |
There was a problem hiding this comment.
note: I think this is fine for now because we don't (yet) allow different colors in different viewers, but when/if we do, we need to get a consensus on what color should be used for the broader Neuron representation (the color that shows in the sidebar)
There was a problem hiding this comment.
@afonsobspinto yes, I thought about that also, but I think it's fine at the moment, we will probably need to reflect a little bit more if we can have different color by viewer as it will also impact the synchronizer probably, or the way we retrieve the information.
afonsobspinto
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.