Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cele 90 improvement #44

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

Salam-Dalloul
Copy link

Update neuron and group visibility logic for newly added groups and hide neurons from side menu when hiding it from the viewer

improvements mentioned HERE

…nd hide neurons from side menu when hiding it from the viewer
@afonsobspinto
Copy link
Member

afonsobspinto commented Sep 17, 2024

Added @aranega as a reviewer as well because this might conflict with the changes made in #41 (yet to be added to develop)

@aranega
Copy link
Member

aranega commented Sep 18, 2024

@ddelpiano It seems that this PR implements the some behaviors that are also part of #38 . After checking with @Salam-Dalloul and @afonsobspinto , it would be better to merge #38 first and to see later what's still relevant from this one.

@aranega aranega marked this pull request as draft September 18, 2024 15:42
@ddelpiano ddelpiano marked this pull request as ready for review September 25, 2024 13:36
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddelpiano It fits well with the last changes, all looks good to me :)!

@ddelpiano ddelpiano merged commit aa00a86 into develop Oct 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants