Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cele 78 #30

Merged
merged 72 commits into from
Oct 11, 2024
Merged

Feature/cele 78 #30

merged 72 commits into from
Oct 11, 2024

Conversation

dvcorreia
Copy link
Member

@dvcorreia dvcorreia commented Aug 28, 2024

Ingestion script

  • connect the validator to the ingestion to pre-validate the dataset to ingest
  • process and convert eventually 3d and json data
    segmentation extraction has been added in its own subcommand (celegans extract ...).
  • push files into the bucket using the pattern designed for the file storage
  • update the database with the new data ingested
  • develop a flag to avoid to re-upload files that already presents in the bucket (fast upload)
    implemented but there's still some issues with the amount of files we are dealing with, which takes a lot of time to upload.
  • develop a flag to upload everything and eventually overwrite what in the bucket (new data entirely, wipe what stored remotely)
    if the hash between the files is the same, nothing happens. if the hash is different and overwrite is true, the new file will overwrite the remote one.
  • add a flag to eventually remove everything from the bucket before the upload

Extra tasks:

  • upload a file to the bucket with the tiles metadata
    we assume that all the tiles in a slice have the same size, otherwise it would take a lot of time to read the tile size from all tiles
    we also have to understand what we want in the metadata.
  • ingestion format documentation
  • check that the specified dataset id in the CLI exists in datasets.json
    the CLI allows the user to partial upload a dataset, so a combination of the data, EM tiles and segmentations.
    currently this check is only evaluated if the data flag is set, otherwise we do not have access to datasets.json
  • update README with usage documentation

@dvcorreia dvcorreia self-assigned this Aug 28, 2024
@dvcorreia dvcorreia changed the base branch from main to develop August 28, 2024 17:13
@dvcorreia dvcorreia marked this pull request as ready for review September 17, 2024 17:46
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me :) I'm being picky on the code, but they are good examples about how some python code can be rewritten to be more pythonic

ingestion/ingestion/ingest.py Outdated Show resolved Hide resolved
ingestion/ingestion/ingest.py Outdated Show resolved Hide resolved
@aranega aranega self-requested a review October 8, 2024 14:07
@ddelpiano ddelpiano merged commit 0bba5f6 into develop Oct 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants