-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cele 78 #30
Merged
Merged
Feature/cele 78 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranega
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me :) I'm being picky on the code, but they are good examples about how some python code can be rewritten to be more pythonic
aranega
force-pushed
the
feature/CELE-78
branch
from
October 8, 2024 13:04
168dc90
to
6794a47
Compare
aranega
force-pushed
the
feature/CELE-78
branch
from
October 8, 2024 13:06
6794a47
to
0d9d652
Compare
aranega
approved these changes
Oct 8, 2024
CELE-99 Add way of pulling information from local FS or the bucket to populate the DB and clean the tables before DB population
EM Viewer Config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingestion script
segmentation extraction has been added in its own subcommand (
celegans extract ...
).implemented but there's still some issues with the amount of files we are dealing with, which takes a lot of time to upload.
if the hash between the files is the same, nothing happens. if the hash is different and
overwrite
istrue
, the new file will overwrite the remote one.Extra tasks:
we assume that all the tiles in a slice have the same size, otherwise it would take a lot of time to read the tile size from all tiles
we also have to understand what we want in the metadata.
datasets.json
the CLI allows the user to partial upload a dataset, so a combination of the data, EM tiles and segmentations.
currently this check is only evaluated if the data flag is set, otherwise we do not have access to
datasets.json