Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cele 46 #24

Merged
merged 30 commits into from
Aug 28, 2024
Merged

Feature/cele 46 #24

merged 30 commits into from
Aug 28, 2024

Conversation

dvcorreia
Copy link
Member

@dvcorreia dvcorreia commented Aug 20, 2024

  • validate data to ingest
  • return meaningful message of what is the problem encountered or the data that are missing

Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks kind of nice :). There is just some quick modifications that should be addressed. Also, the code for the ingestion should be placed in a dedicated folder at the root of the repository, it's a tool that will be used from the user machine, it's not part of the backend per say.

@dvcorreia
Copy link
Member Author

@aranega, I just moved the code to the project root. Is it ok to define the package like this or do you prefer that I remove the pyproject.toml?

@aranega
Copy link
Member

aranega commented Aug 21, 2024

@dvcorreia Thanks for the modifications! For the project at the root as you did is just perfect!

If you have time, perhaps add a README in this folder explaining how to install the project, what's and how to use it (or at least install it while it's a WIP), and an entry in the README at the root of the project explaining that the data ingestion is done using this project and that it needs to be installed/managed manually.

@dvcorreia
Copy link
Member Author

Is it ok for this to be done in https://metacell.atlassian.net/browse/CELE-78? I already have a README ready for it.

@dvcorreia Thanks for the modifications! For the project at the root as you did is just perfect!

If you have time, perhaps add a README in this folder explaining how to install the project, what's and how to use it (or at least install it while it's a WIP), and an entry in the README at the root of the project explaining that the data ingestion is done using this project and that it needs to be installed/managed manually.

@aranega
Copy link
Member

aranega commented Aug 21, 2024

Sure, no problem if it's in CELE-78 :)

@dvcorreia dvcorreia marked this pull request as ready for review August 21, 2024 14:51
@dvcorreia dvcorreia marked this pull request as draft August 22, 2024 11:57
@dvcorreia dvcorreia self-assigned this Aug 22, 2024
@dvcorreia
Copy link
Member Author

Latest changes:

  • now I uses a colors package (colorama, don't if is the "best", but was close to what I had previously and I think it fixes some ANSI issues on windows)
  • not there's a wrapper for the data validation error
  • added a few tests for the find and load data functions

@dvcorreia dvcorreia marked this pull request as ready for review August 27, 2024 18:17
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :) thanks for addressing the previous concerns. There is few modification I would suggest, nothing too huge, it's more polishing for this version.

ingestion/ingestion/__main__.py Outdated Show resolved Hide resolved
ingestion/ingestion/errors.py Outdated Show resolved Hide resolved
ingestion/ingestion/errors.py Outdated Show resolved Hide resolved
ingestion/ingestion/errors.py Outdated Show resolved Hide resolved
ingestion/ingestion/filesystem.py Outdated Show resolved Hide resolved
@aranega aranega self-requested a review August 28, 2024 13:50
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me :) thanks a lot @dvcorreia !

@aranega aranega merged commit 11fa422 into develop Aug 28, 2024
6 checks passed
@aranega aranega deleted the feature/CELE-46 branch August 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants