-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cele 46 #24
Feature/cele 46 #24
Conversation
dvcorreia
commented
Aug 20, 2024
•
edited
Loading
edited
- validate data to ingest
- return meaningful message of what is the problem encountered or the data that are missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks kind of nice :). There is just some quick modifications that should be addressed. Also, the code for the ingestion
should be placed in a dedicated folder at the root of the repository, it's a tool that will be used from the user machine, it's not part of the backend
per say.
applications/visualizer/backend/tests/ingestion/test_validator.py
Outdated
Show resolved
Hide resolved
applications/visualizer/backend/tests/ingestion/test_validator.py
Outdated
Show resolved
Hide resolved
applications/visualizer/backend/tests/ingestion/test_validator.py
Outdated
Show resolved
Hide resolved
@aranega, I just moved the code to the project root. Is it ok to define the package like this or do you prefer that I remove the |
@dvcorreia Thanks for the modifications! For the project at the root as you did is just perfect! If you have time, perhaps add a README in this folder explaining how to install the project, what's and how to use it (or at least install it while it's a WIP), and an entry in the README at the root of the project explaining that the data ingestion is done using this project and that it needs to be installed/managed manually. |
Is it ok for this to be done in https://metacell.atlassian.net/browse/CELE-78? I already have a README ready for it.
|
Sure, no problem if it's in CELE-78 :) |
…colors instead of ours
Latest changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :) thanks for addressing the previous concerns. There is few modification I would suggest, nothing too huge, it's more polishing for this version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me :) thanks a lot @dvcorreia !