Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cele 70 #18

Merged
merged 14 commits into from
Sep 3, 2024
Merged

Feature/cele 70 #18

merged 14 commits into from
Sep 3, 2024

Conversation

Salam-Dalloul
Copy link

No description provided.

@Salam-Dalloul Salam-Dalloul marked this pull request as ready for review August 6, 2024 12:55
afonsobspinto
afonsobspinto requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): Any chance we can fix the electrical connection style for connections to themselves like AIY?
image
image
image

afonsobspinto
afonsobspinto requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): The group styles make it look like it's selected even when it's not:
image
image

afonsobspinto
afonsobspinto requested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): Would it be possible to have the align options appear on hover instead of on click (that's the behaviour in the original nemanode app)?

@afonsobspinto afonsobspinto changed the base branch from feature/CELE-32_iteration2 to develop August 12, 2024 15:16
@afonsobspinto
Copy link
Member

@Salam-Dalloul would it be possible to also style the open groups? This is a feature I'm introducing with this PR.
I would propose you pull my branch into yours and style it here. But if it raises too much conflicts we can address this later when both are merged into develop

afonsobspinto
afonsobspinto requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The align submenu is opening when I open the context menu:

image

Would you be able to fix that?

afonsobspinto
afonsobspinto requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@afonsobspinto afonsobspinto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a group is selected can we have a bold title or border like this:
image

vs

image

@ddelpiano ddelpiano merged commit 96df2d4 into develop Sep 3, 2024
8 checks passed
@ddelpiano ddelpiano deleted the feature/CELE-70 branch September 3, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsobspinto afonsobspinto afonsobspinto approved these changes

@ddelpiano ddelpiano Awaiting requested review from ddelpiano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Salam-Dalloul @afonsobspinto @ddelpiano @aranega